Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stock): hide expiration date on asset entry #6633

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented May 25, 2022

This commit ensures that the expiration date is hidden on asset entry.

Closes #6588.

To test:

  1. Create or update an asset in the inventory list.
  2. Attempt a stock entry.
  3. Note that the expiration date column in the "Lots" modal is not visible.
  4. Attempt a stock entry with a regular lot.
  5. Note that the column is now visible.

This commit ensures that the expiration date is hidden on asset entry.

Closes Third-Culture-Software#6588.
@jniles jniles requested a review from jmcameron May 25, 2022 09:19
Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over the code changes and they seem fine.
I tested it with Bhima_test and it works as described.

@jmcameron
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented May 25, 2022

Build succeeded:

@bors bors bot merged commit 5e0672b into Third-Culture-Software:master May 25, 2022
@jniles jniles deleted the 6588-fix-hide-expiration-dates-on-stock-entry branch May 25, 2022 10:12
@jniles jniles added the Stock label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide expiration date for assets in stock entry
2 participants