Fixed issue with upload directories

[jmcameron]

Fix issue with upload directory always being under the bin directory. Now it obeys the .env setting for UPLOAD_DIR.

NOTES!

• Only relative paths within the Bhima installation directory may be used
• Currently it will reject any absolute paths or paths that start with '..' for UPLOAD_DIR.
• Although it is probably possible to support absolute paths outside the Bhima installation, it will require updates to the app's 'app.use' function calls. Without those changes, paths outside of the Bhima directory cannot be accessed via HTTPS calls without ENOENT errors.
• There are at least 3 ways to avoid conflicts with installation updates:
  • Create a new 'data' (or similar) directory inside the Bhima installation folder and add it to the .gitignore file.
  • Create a directory elsewhere and set up a symbolic/hard link to it within the Bhima directory
  • Revisit this issue and refactor to allow absolute paths.

TESTING:

• In your .env file, try changing UPLOAD_DIR to an absolute path and then a path beginning with '..'. These should both fail.
  • NOTE that these failures are not handled very gracefully because this is an error that should be handled by the installer, not an end-user.
• Test the current default for the upload directory (eg, 'client/uploads'
  • Try uploading a file (eg in the Patient Registry, chose a patient and upload a document)
  • Verify the upload worked and the file is downloadable. Do not delete it.
• Test in a new directory:
  • Use 'bhima_test'
  • Create a folder within the Bhima installation directory (eg, 'data')
  • Change UPLOAD_DIR to the relative path for the new subdirectory the Bhima installation directory (eg, 'data').
  • Enable the debugging option in .env: DEBUG=app,errors,app:uploader
  • Monitor the client console for errors
  • Run 'yarn dev', notice in the server console the paths match what was given. Also notice that it is NOT in the bin directory!
  • Try uploading a file (eg in the Patient Registry, chose a patient and upload a document)
  • Verify the upload worked and the file is downloadable
  • Delete the new file
  • Exit 'yarn dev' and delete the temporary upload folder
• Revert to the default UPLOAD directory (eg, 'client/uploads') and verify it still works and that the file uploaded earlier is still accessible. Delete the file, if desired.
• Undo the debug settings in .env

[jniles]

This isn't guaranteed to be the root directory in all circumstances. As explained in this SO answer, the process.cwd() is wherever the node call was made. So, it can changed, depending on where the executing terminal is in the file system.

Instead, you probably want __dirname. Here is a really good tutorial explaining how it works. This will never change, no matter who calls it or from where it is called.

[jniles]

Sorry about the force push 😞

[jniles]

Got it working. Thanks so much for your help @jmcameron !

bors r+

[bors]

Build succeeded:

• ci/semaphoreci/push: Integration Tests