Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better explanation of UPLOAD_DIR #5271

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Add better explanation of UPLOAD_DIR #5271

merged 1 commit into from
Jan 8, 2021

Conversation

jmcameron
Copy link
Collaborator

Based on updates in PR #5269.

@jmcameron jmcameron linked an issue Jan 6, 2021 that may be closed by this pull request
UPLOAD_DIR doesn't seem to accept absolute paths #5207
Closed
@jmcameron jmcameron requested a review from jniles January 6, 2021 18:58
@jmcameron jmcameron changed the title Added better explanation of UPLOAD_DIR Add better explanation of UPLOAD_DIR Jan 6, 2021
jniles
jniles approved these changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@jniles jniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 8, 2021

Build succeeded:

@bors bors bot merged commit fcdf5d5 into Third-Culture-Software:master Jan 8, 2021
@jmcameron jmcameron deleted the document_upload_dir branch January 8, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jniles jniles jniles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UPLOAD_DIR doesn't seem to accept absolute paths
2 participants
@jmcameron @jniles