-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve find transfer/purchase modals #5644
chore: improve find transfer/purchase modals #5644
Conversation
This commit refactors and improves the find transfer modal in the stock entry section. Notably, it adds a working loading button and removes the listener on every grid change, as well as tightening up the HTML.
This commit brings some minor improvements to the find purchase modal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and doing Stock entry from Purchase Orders works nicely.
I was unable to test it using Transfers because I not sure how to do that.
I did notice one small oddity. To reproduce
- In (fresh) Bhima_test, there are two purchase orders.
- Edit the status and confirm the second (unconfirmed) one.
- Do stock entry and select the PO you just confirmed
- Enter the lots for second item (pred...) and increase the global number to 400 and do the entry for that number
- Back in the main entry form delete the first item (pretend that a partial delivery was sent).
- Submit the form to complete the entry
- Go back to the Purchase registry and notice the status.
- It is correct but it hides the fact that the order is incomplete.
I'll take a look at your scenarios a bit more tomorrow. We should have migrated to a new location by then. Thanks for your review! |
@jmcameron finally took a look at this. You are right, this is confusing. There are two simultaneous errors - one item wasn't received at all and the other one was received over-stock. Yet, we only show the second case. Perhaps, instead of trying to say "received excessively", we should put something more generic like "Received Incoherently" and just link the "Analysis of Purchase Order" report (note though, this this has errors in master - #5429). I'll create an issue for further discussion. |
Since this got approval and the discussion revolves around purchase orders, I'm merging this. bors r+ |
Build succeeded: |
This PR tightens up the code of both transfer modals for stock entry. Their behavior should be nearly identical.
Here are the improvements:
bh-filter-toggle
directive for toggling the grid's filtering.