-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(Payroll for HGR) #7159
feature(Payroll for HGR) #7159
Conversation
08ee1d4
to
ac953e8
Compare
@@ -524,6 +524,7 @@ CREATE TABLE `employee` ( | |||
`patient_uuid` BINARY(16) DEFAULT NULL, | |||
`is_medical` TINYINT(1) DEFAULT 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the is_medical
to the title_employee
table? It seems like is_medical
has to do with the employee's job title, not the employee themselves, right?
From this implementation, I assume all employees have titles? Can multiple employees have the same title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a really good idea that would make things a lot easier. I can do it in another PR
- Update and improve modal of Payslip for HGR
PAYROLL FOR HGR.pdf Here are sample SQL data files (source these after loading bhima_test by doing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a brief look through the code and it seems okay.
I've tested this PR (with training and assistance from Chris) and it seems to work fine.
I suggest we go ahead and merge it. I have some improvements to do (eg, for some of the English translations) but I plan to do those later.
bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
closes #7158