Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reports): remove stock changes report #7160

Merged

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Jul 23, 2023

This commit removes the stock_changes report, useful only for manual stock calculations and never implemented in practice. The same functionality (keeping track of stock offline) has been implemented in the BHIMA Stock Android application.

Closes #7103.

This commit removes the stock_changes report, useful only for manual
stock calculations and never implemented in practice.  The same
functionality (keeping track of stock offline) has been implemented in
the BHIMA Stock Android application.

Closes Third-Culture-Software#7103.
@jniles jniles force-pushed the chore-remove-stock-changes-report branch from 7b7a292 to ab1a506 Compare July 24, 2023 15:07
Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine. I'm happy to merge this PR. But I would like Bruce to give me a second opinion since I'm not familiar with this report or how it was used.

Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good.

I tested this with bhima_test and it seems to work fine. I did not test the migration SQL file.

@jmcameron
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 21, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f4b1270 into Third-Culture-Software:master Aug 21, 2023
@jniles jniles deleted the chore-remove-stock-changes-report branch August 21, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we still need the stock changes report?
2 participants