chore: remove odk-central plugin #7199
Conversation
|
@jniles could you fix the conflict so that we can merge this PR? |
Removes all references to ODK Central in the code base. Adds migration scripts to drop ODK Central tables. Closes Third-Culture-Software#7190. Closes Third-Culture-Software#6672. Closes Third-Culture-Software#6671.
jniles
force-pushed
the
7190-chore-remove-odk-central
branch
from
00f935d to
dad7968
Compare
|
@mbayopanda done! |
|
I discussed this with Bruce and he suggested that we set up the code for the ODK central plugin in a separate github repository before removing it from Bhima. |
|
I am not totally sure I understand. The code will always be there in the git history, and the ODK api is already in https://github.com/IMA-WorldHealth/odk-central-api-cjs/, though no one is maintaining it. I don't have time to maintain it myself. So ... what needs to be transferred? And what purpose will it serve? If there isn't an interest in this PR, I can just close it as well, no harm done. |
|
@jniles Since we have this repository https://github.com/IMA-WorldHealth/odk-central-api-cjs/ we can remove the code from BHIMA, my concern was about losing all the work we have done with this API. I forgot we had a repository for that. Thank you for your feedback. @jmcameron you can go on merging this PR. |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This commit finishes the work done in Third-Culture-Software#7199, by removing all additional references, dependencies, documentation, and translation related to the ODK plugin. This includes: 1. The ODK i18n files. 2. The English ODK plugin documentation. 3. The legacy ODK Settings service. 4. The QR Code links and dependencies. The work on the ODK connection has now been completely reversed. Closes Third-Culture-Software#7214.
7216: fix(odk): clean up all remaining ODK references r=jmcameron a=jniles This commit finishes the work done in #7199, by removing all additional references, dependencies, documentation, and translation related to the ODK plugin. This includes: 1. The ODK i18n files. 2. The English ODK plugin documentation. 3. The legacy ODK Settings service. 4. The QR Code links and dependencies. The work on the ODK connection has now been completely reversed. Closes #7214. Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Removes all references to ODK Central in the code base. Adds migration scripts to drop ODK Central tables.
Closes #7190.
Closes #6672.
Closes #6671.