Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(odk): clean up all remaining ODK references #7216

Merged

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Aug 23, 2023

This commit finishes the work done in #7199, by removing all additional references, dependencies, documentation, and translation related to the ODK plugin. This includes:

  1. The ODK i18n files.
  2. The English ODK plugin documentation.
  3. The legacy ODK Settings service.
  4. The QR Code links and dependencies.

The work on the ODK connection has now been completely reversed.

Closes #7214.

This commit finishes the work done in Third-Culture-Software#7199, by removing all additional
references, dependencies, documentation, and translation related to the
ODK plugin.  This includes:

 1. The ODK i18n files.
 2. The English ODK plugin documentation.
 3. The legacy ODK Settings service.
 4. The QR Code links and dependencies.

The work on the ODK connection has now been completely reversed.

Closes Third-Culture-Software#7214.
@jmcameron
Copy link
Collaborator

Thanks!

Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested it and the user management page works fine.

@jmcameron
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 23, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 1a9767b into Third-Culture-Software:master Aug 23, 2023
@jniles jniles deleted the 7214-remove-odk-settings-service branch August 23, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up ODK residue and refactor ODKSettingsService
2 participants