Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates for employee registry and rubrics management page #7237

Merged

Conversation

jmcameron
Copy link
Collaborator

This PR implements some minor changes for the employee registry and the payroll rubrics management page.

  • When editing an employee, the "Submit" button now reads "Update Employee" instead of "Register Employee"
  • Fixed various English payroll-related terms (eg, "grapped" (saiser) should be changed to "entered")
  • Add an Index type column to the Rubric management page (if using indexes). Hovering over the labels in these cells will bring up a tooltip describing them.

Closes #7206

This are just a few superficial fixes. The terminology (in English) for all payroll activities needs to be scrubbed.

@jmcameron jmcameron requested a review from jniles August 29, 2023 12:13
@jmcameron jmcameron force-pushed the minor-payroll-and-employee-fixes branch from 47e701d to 0d76073 Compare August 29, 2023 12:17
@lomamech lomamech self-requested a review August 30, 2023 04:38
Copy link
Collaborator

@lomamech lomamech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image
image

@jmcameron
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 30, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 11e1a0f into Third-Culture-Software:master Aug 30, 2023
@jmcameron jmcameron deleted the minor-payroll-and-employee-fixes branch August 31, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements for multiple index payroll (HGR)
2 participants