Widen PHP support #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you setup a CI matrix that tests all versions? At least 7.2 and 8.3. That might be enough. |
|
Thanks. Do you think it would be good to also include a unit test? If you're up to it that would be great. 🙌 |
|
@juliangut would you be up for that? |
|
sorry, at this moment I was interested only on the PHP version support, don't think I have the time to create a test suite but I think it's a good idea of course |
ruudk
added a commit
that referenced
this pull request
Oct 2, 2024
ruudk
added a commit
that referenced
this pull request
Oct 3, 2024
This broke in #10. The condition was wrong. Added tests to assure this won't break again.
ruudk
added a commit
that referenced
this pull request
Oct 3, 2024
This broke in #10. The condition was wrong. Added tests to assure this won't break again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know PHP 7.2 is already EOL but hear me out
This PR widens PHP support for the formatter to match requested PHPStan version 1.12.4, which supports PHP ^7.2|^8.0
The updates are the absolute minimum necessary to allow PHP 7.2 support, no behaviour is altered, added or removed
Given supported PHPStan version supports 7.2 I think this PR could be a reasonable change