-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PHP 7.2 support and require at least 8.1 #14
Conversation
This reverts commit 7532a89.
PHPStan 2.0 is in the works, and it will only support 8.1 and higher.
I understand the reasoning behind PHPStan 2* supported versions in the near future, but I'd point out it is exactly the same point I made about PHPStan 1* supported versions now. It's a pity there will not be a version of this package with support for what PHPStan 1* supports |
Do you have a specific use case where this is a problem? Or is this a hypothetical problem? |
According to phpstan/phpstan#4060 (comment) you only have to run PHPStan twice, on PHP 7 and PHP 8. That means it could run on PHP 7.4 and 8.x. That would make it a little bit easier, as then we can get typed properties and such. |
I'm currently working on a 7.3/7.4 codebase which won't be updated in the near future to 8* so I'm stuck in this project with PHPStan 1* in the foreseeable future. There are many legacy codebase that are not being updated and developers on those codebase, but we all can benefit greatly from PHPStan in any version, and we could benefit from this formatter as well |
So what if we lower it to PHP 7.4 then? |
I thought so at the beginning, then I had a look at PHPStan version supported (1.12.4) and I saw they support 7.2 and so I dive deeper |
Ok, let's see what this brings: #15 |
Great 👍🏾 |
@juliangut I thought about your change #10, and decided to undo it. The reason for this is that PHPStan 2.0 is in the works, and it will only support 8.1 and higher. Given that is going to be released in the coming months (?) I don't want to struggle with these old unsupported PHP versions.