-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to use aws sdk 1.9.291 #3353
Changes from all commits
31c17bc
d29ef23
76afa25
2f8d0a8
4ea5e3a
a434181
ffdc10f
c42effb
71d5683
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
diff --git "a/crt/aws-crt-cpp/crt/aws-c-io/source/event_loop.c" "b/crt/aws-crt-cpp/crt/aws-c-io/source/event_loop.c" | ||
index 5eb8a084ac..e46cec1dfd 100644 | ||
--- "a/crt/aws-crt-cpp/crt/aws-c-io/source/event_loop.c" | ||
+++ "b/crt/aws-crt-cpp/crt/aws-c-io/source/event_loop.c" | ||
@@ -70,9 +70,16 @@ static void s_aws_event_loop_group_shutdown_async(struct aws_event_loop_group *e | ||
thread_options.cpu_id = -1; | ||
thread_options.join_strategy = AWS_TJS_MANAGED; | ||
|
||
+ /* | ||
+ * tiledb encountered issue similar to https://github.com/huggingface/datasets/issues/3310#issuecomment-1155285967. | ||
+ */ | ||
+#if 1 | ||
+ aws_thread_launch(&cleanup_thread, s_event_loop_destroy_async_thread_fn, el_group, &thread_options); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you are able to easily reproduce the issue mentioned above, could you please check There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also a stack trace - I believe the problem is that they are trying to launch a thread after process exit has started, which fails (even on POSIX). See
|
||
+#else | ||
AWS_FATAL_ASSERT( | ||
aws_thread_launch(&cleanup_thread, s_event_loop_destroy_async_thread_fn, el_group, &thread_options) == | ||
AWS_OP_SUCCESS); | ||
+#endif | ||
} | ||
|
||
static struct aws_event_loop_group *s_event_loop_group_new( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The underlying issue is here:
https://github.com/aws/aws-sdk-cpp/issues/1809
Please link that too, and add a short summary so that we have some context to start from even if the linked comment disappears.