Do not provide storage URIs in TileDB-Server REST requests. #5687
Conversation
test/src/unit-capi-array.cc
Outdated
| tiledb_encryption_type_t encryption_type_ = TILEDB_NO_ENCRYPTION; | ||
| const char* encryption_key_ = nullptr; | ||
|
|
||
| // TODO: Update ArrayFx to use VFSTestSetup. |
There was a problem hiding this comment.
Porting this to VFSTestSetup quickly became a lot of work and I didn't want to hold up the PR. I can do this as follow up to remove the duplication between this fixture and VFSTestSetup.
test/support/src/vfs_helpers.h
Outdated
| * @param creation_uri The URI passed to array / group create request. | ||
| * @return The backend storage location for the created array / group. | ||
| */ | ||
| std::string get_rest_array_uri(const std::string& creation_uri) const { |
There was a problem hiding this comment.
Default storage generates a unique array / group ID and uses this as the prefix within the default storage location to create the asset. Currently it's a bit awkward for clients to create an array / group and not know where it lives.
If we don't support custom storage locations moving forward, there could be a response from the server to tell core where the array was created, or an endpoint to request the backend location of an asset given its tiledb URI. The latter might exist server side already, but I don't believe we have support for it in core if it does.
This hack works for our tests but that's very likely only because the bucket is emptied after each test in the destructor.
There was a problem hiding this comment.
The info about the storage prefix backing the tiledb:// asset exists in the UI, and (will?) exists in TileDB-Client. Core can unfortunately not use any of those, so if you've got a suggestion/idea on how we could do that " response from the server" or something similar, please open a ticket.
shaunrd0
deleted the
shaunreed/core-430-do-not-allow-custom-storage-uris-within-tiledb-server-array
branch
|
/backport to release-2.29 |
|
Started backporting to release-2.29: https://github.com/TileDB-Inc/TileDB/actions/runs/19507074322 |
|
@shaunrd0 backporting to "release-2.29" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Support for custom storage paths was removed in TileDB-Server, causing REST CI failures since core sets the URI field for array / group creation requests. This updates the requests to not set the URI field if we are talking to a 3.0 REST server. --- TYPE: BUG DESC: Do not provide storage URIs in TileDB-Server REST requests.
This backports #5687 to release 2.29 following changes in tiledb-server to remove custom URIs from request body during array / group creation. #5692 was also backported to fix SSL errors after some changes to REST CI to support `tiledb://` VFS testing: https://github.com/TileDB-Inc/TileDB-Internal/actions/runs/19505457900/job/55833344767 --- TYPE: NO_HISTORY DESC: Backport #5687 and #5692 to release-2.29. --------- Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
Support for custom storage paths was removed in TileDB-Server, causing REST CI failures since core sets the URI field for array / group creation requests. This updates the requests to not set the URI field if we are talking to a 3.0 REST server.
TYPE: BUG
DESC: Do not provide storage URIs in TileDB-Server REST requests.