Do not override VFS config options in REST CI. #5692
Conversation
teo-tsirpanis
force-pushed
the
teo/rest-ci-env-vars
branch
from
b77f60c to
465ab8f
Compare
teo-tsirpanis
changed the title
teo-tsirpanis
force-pushed
the
teo/rest-ci-env-vars
branch
from
465ab8f to
530b436
Compare
| [[maybe_unused]] tiledb_config_t* config, | ||
| [[maybe_unused]] tiledb_error_t* error) { | ||
| #ifndef TILEDB_TESTS_AWS_S3_CONFIG | ||
| if (rest_) { |
There was a problem hiding this comment.
Could we set tiledb_tests_aws_s3_config in build-libtiledb.sh on the internal repository when we bootstrap the core build? Either way SGTM so approved, but the ifndef above seems like it could accomplish this
There was a problem hiding this comment.
We could, but it is misleading, since we don't actually test on Amazon S3. I would like us eventually to entirely remove VFS configuration from test code, and rely on environment variables.
|
/backport to release-2.29 CI fails on |
|
Started backporting to release-2.29: https://github.com/TileDB-Inc/TileDB/actions/runs/19507096686 |
|
@shaunrd0 backporting to "release-2.29" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
This backports #5687 to release 2.29 following changes in tiledb-server to remove custom URIs from request body during array / group creation. #5692 was also backported to fix SSL errors after some changes to REST CI to support `tiledb://` VFS testing: https://github.com/TileDB-Inc/TileDB-Internal/actions/runs/19505457900/job/55833344767 --- TYPE: NO_HISTORY DESC: Backport #5687 and #5692 to release-2.29. --------- Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
Extracts 4e56a79 from #5631, in order to unblock changes to REST CI needed for that PR.
TYPE: NO_HISTORY