Skip to content

Do not override VFS config options in REST CI. #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
+4 −0
Merged

Do not override VFS config options in REST CI. #5692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/support/src/vfs_helpers.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ Status SupportedFsS3::prepare_config(
[[maybe_unused]] tiledb_config_t* config,
[[maybe_unused]] tiledb_error_t* error) {
#ifndef TILEDB_TESTS_AWS_S3_CONFIG
if (rest_) {
Copy link
Member

@shaunrd0 shaunrd0 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we set tiledb_tests_aws_s3_config in build-libtiledb.sh on the internal repository when we bootstrap the core build? Either way SGTM so approved, but the ifndef above seems like it could accomplish this

Copy link
Member Author

@teo-tsirpanis teo-tsirpanis Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but it is misleading, since we don't actually test on Amazon S3. I would like us eventually to entirely remove VFS configuration from test code, and rely on environment variables.

// REST CI gets configured by environment variables.
return Status::Ok();
}
REQUIRE(
tiledb_config_set(
config, "vfs.s3.endpoint_override", "localhost:9999", &error) ==
Expand Down
Loading