feat: add option to rename, enable disable catalogs #24
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @TimilsinaBimal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user's ability to customize their recommendation experience by introducing more granular catalog types and providing full control over their names and visibility. It refactors the backend to support these new catalog IDs and simplifies an API endpoint, while also improving the logic for year-based content discovery. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the catalog system to introduce distinct 'loved' and 'watched' recommendation categories, replacing the single 'item-based' catalog. The changes involve updating catalog ID handling across API endpoints and manifest generation, modifying default user settings to include the new 'watchly.loved' and 'watchly.watched' catalogs, and adjusting the frontend script to reflect these new catalog types and allow all catalogs to be renamable. Additionally, the discovery service now uses a 10-year bucket for 'top year' recommendations, and a new get_top_year method was added to the profile model. Review comments suggest improving code readability and maintainability by using any() for id.startswith checks, re.sub for item ID extraction, moving import datetime to the top of the file, and defining default catalog names as constants to avoid hardcoding.
| last_loved = loved[0] if loved else None | ||
| if last_loved: | ||
| label = loved_config.name | ||
| if not label or label == "More like what you loved": # Default |
There was a problem hiding this comment.
The default catalog name "More like what you loved" is hardcoded here and in other files (e.g., app/core/settings.py, app/static/script.js). To improve maintainability and ensure consistency, it's better to define this string as a constant in a central location (like a new app/core/constants.py file) and import it where needed.
| if not label or label == "More like what you loved": # Default | |
| if not label or label == DEFAULT_LOVED_CATALOG_NAME: # Default |
|
|
||
| if last_watched: | ||
| label = watched_config.name | ||
| if not label or label == "Because you watched": |
There was a problem hiding this comment.
Similar to the 'loved' catalog, the default name "Because you watched" is hardcoded. This should also be defined as a constant in a central location to avoid inconsistencies and make future updates easier.
| if not label or label == "Because you watched": | |
| if not label or label == DEFAULT_WATCHED_CATALOG_NAME: |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* feat: add option to rename, disable, reorder catalogs * feat: new recommendation system based on weights * feat: dynamic row generator * feat: add dynamic row generator with country flag * feat: add watched.loved row * feat: new ui with stremio auth button * feat: add languages selection button in ui for tmdb meta * feat: add option to enable rpdb api key for posters * feat: ui improvements * chore: add vercel app env * chore: improve recommendation weights and refactor * chore: remove unnecessary country flags * add workflows to bump version * chore: bump version to 1.0.0-rc.1 * chore: bump version to 1.0.0-rc.2 * chore: use redis token from config * fix: priotrize keywords for row generation than genre * chore: bump version to v1.0.0-rc.3 * feat: add option to delete account * refactor: update token deletion API to use DELETE / and implement deep cloning for catalog data in the frontend, removing conditional name handling. * opt: improve recommendations using larger candidate pool and better similarity methods * feat: Add genre exclusion UI, store excluded genres in user settings,and apply them during catalog generation (#21) * feat: Add genre exclusion UI, store excluded genres in user settings, and apply them during catalog generation. * refactor: simplify filtering recommendations by excluded genres using list comprehension * refactor: streamline genre exclusion logic for similarity recommendations * feat: Rework UI into a multi-step setup wizard with account management and section navigation (#22) * feat: Rework UI into a multi-step setup wizard with Watchly account management and section navigation * critical: check if user already exists * refactor: remove disabled class from source code button * feat: add translation service to translate catalog names to user language (#23) * feat: add option to rename, enable disable catalogs (#24) * feat: Implement user ID-based token management and Stremio user info fetching, replacing credential-derived tokens and direct login. (#25) * refactor: code refactoring and remove legacy code and components (#26) * feat: add option to rename, enable disable catalogs * feat: add option to rename, enable disable catalogs * feat: Implement user ID-based token management and Stremio user info fetching, replacing credential-derived tokens and direct login. * feat: Implement user ID-based token management and Stremio user info fetching, replacing credential-derived tokens and direct login. * feat: Refactor token management to use a dedicated token model, remove token salt, and streamline catalog refresh logic. * feat: Encrypt auth keys in token store and enforce 401 for invalid tokens across endpoints. * feat: Introduce token redaction utility and apply it to log messages for enhanced security. * feat: Introduce token redaction utility and apply it to log messages for enhanced security. * fernet client management * feat: add migration script to migrate old tokens to new system * feat: check and only update tokens that are installed from the same system * opt: give more weight to items watched recently * docs: add contributing guidelines and acknowledgements * opt: optimize translation service * chore: bump version to v1.0.0-rc.6 * feat: add gemini service to generate catalog names (#29) * Refactor services for improved async handling and error resilience (#30) * refactor: fetch loved and liked items at once and use that * Refactor services for improved async handling and error resilience * chore: bump version to v1.0.0 * feat: better bare row name generation (#32)
No description provided.