feat: better bare row name generation #32
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @TimilsinaBimal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the process of generating "bare" row names, specifically when the primary content generation service (Gemini) does not return a title. The changes reorder the concatenation of string components, ensuring that descriptive elements such as keywords, country adjectives, or decades precede the genre name in the fallback title, aiming for a more intuitive and consistent naming convention. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
* feat: add option to rename, disable, reorder catalogs * feat: new recommendation system based on weights * feat: dynamic row generator * feat: add dynamic row generator with country flag * feat: add watched.loved row * feat: new ui with stremio auth button * feat: add languages selection button in ui for tmdb meta * feat: add option to enable rpdb api key for posters * feat: ui improvements * chore: add vercel app env * chore: improve recommendation weights and refactor * chore: remove unnecessary country flags * add workflows to bump version * chore: bump version to 1.0.0-rc.1 * chore: bump version to 1.0.0-rc.2 * chore: use redis token from config * fix: priotrize keywords for row generation than genre * chore: bump version to v1.0.0-rc.3 * feat: add option to delete account * refactor: update token deletion API to use DELETE / and implement deep cloning for catalog data in the frontend, removing conditional name handling. * opt: improve recommendations using larger candidate pool and better similarity methods * feat: Add genre exclusion UI, store excluded genres in user settings,and apply them during catalog generation (#21) * feat: Add genre exclusion UI, store excluded genres in user settings, and apply them during catalog generation. * refactor: simplify filtering recommendations by excluded genres using list comprehension * refactor: streamline genre exclusion logic for similarity recommendations * feat: Rework UI into a multi-step setup wizard with account management and section navigation (#22) * feat: Rework UI into a multi-step setup wizard with Watchly account management and section navigation * critical: check if user already exists * refactor: remove disabled class from source code button * feat: add translation service to translate catalog names to user language (#23) * feat: add option to rename, enable disable catalogs (#24) * feat: Implement user ID-based token management and Stremio user info fetching, replacing credential-derived tokens and direct login. (#25) * refactor: code refactoring and remove legacy code and components (#26) * feat: add option to rename, enable disable catalogs * feat: add option to rename, enable disable catalogs * feat: Implement user ID-based token management and Stremio user info fetching, replacing credential-derived tokens and direct login. * feat: Implement user ID-based token management and Stremio user info fetching, replacing credential-derived tokens and direct login. * feat: Refactor token management to use a dedicated token model, remove token salt, and streamline catalog refresh logic. * feat: Encrypt auth keys in token store and enforce 401 for invalid tokens across endpoints. * feat: Introduce token redaction utility and apply it to log messages for enhanced security. * feat: Introduce token redaction utility and apply it to log messages for enhanced security. * fernet client management * feat: add migration script to migrate old tokens to new system * feat: check and only update tokens that are installed from the same system * opt: give more weight to items watched recently * docs: add contributing guidelines and acknowledgements * opt: optimize translation service * chore: bump version to v1.0.0-rc.6 * feat: add gemini service to generate catalog names (#29) * Refactor services for improved async handling and error resilience (#30) * refactor: fetch loved and liked items at once and use that * Refactor services for improved async handling and error resilience * chore: bump version to v1.0.0 * feat: better bare row name generation (#32)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the generation of bare row names by reordering the components to be more natural (e.g., 'Korean Action' instead of 'Action Korean'). The changes are consistent and improve the user experience. I've suggested a couple of minor improvements to ensure consistency in handling potential duplicate words in the generated titles, mirroring a pattern already present in one of the modified sections.
| title = await gemini_service.generate_content_async(f"Genre: {get_gname(g_id)} + Country: {c_adj}") | ||
| if not title: | ||
| title = f"{get_gname(g_id)} {c_adj}" | ||
| title = f"{c_adj} {get_gname(g_id)}" |
There was a problem hiding this comment.
For consistency with the keyword + genre title generation (lines 111-113), you should also handle potential duplicate words here. While it's unlikely for a country adjective and a genre name to be identical, adding the deduplication logic would make the code more robust and consistent. This also improves readability by separating the title creation from the deduplication.
title = f"{c_adj} {get_gname(g_id)}"
title = " ".join(dict.fromkeys(title.split()))| title = await gemini_service.generate_content_async(f"Genre: {get_gname(g_id)} + Era: {decade_str}") | ||
| if not title: | ||
| title = f"{get_gname(g_id)} {decade_str}" | ||
| title = f"{decade_str} {get_gname(g_id)}" |
There was a problem hiding this comment.
For consistency with the keyword + genre title generation (lines 111-113), you should also handle potential duplicate words here. While it's highly unlikely for a decade string and a genre name to be identical, adding this deduplication logic improves robustness and consistency. This also improves readability by separating the title creation from the deduplication.
title = f"{decade_str} {get_gname(g_id)}"
title = " ".join(dict.fromkeys(title.split()))
No description provided.