fix: invalidate cache on delete/store

[TimilsinaBimal]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
watchly	Ready	Preview, Comment	Dec 15, 2025 7:43am

[gemini-code-assist]

Summary of Changes

Hello @TimilsinaBimal, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving data freshness and consistency by implementing robust cache invalidation strategies. It prevents client-side caching for the manifest endpoint and ensures that the internal token store's data cache is always up-to-date following any storage or deletion operations, thereby eliminating potential issues with stale data being served.

Highlights

• Manifest Cache Control: The Cache-Control header for the manifest endpoint has been updated to no-cache, ensuring that clients always fetch the latest manifest data and do not rely on stale cached versions.
• Token Store Cache Invalidation on Data Storage: When user data is stored via store_user_data, the get_user_data async LRU cache is now explicitly invalidated. This ensures that subsequent reads reflect the newly stored data, preventing stale cache entries.
• Token Store Cache Invalidation on Token Deletion: Upon deletion of a token using delete_token, the get_user_data async LRU cache is also invalidated. This guarantees that deleted tokens are no longer served from the cache, maintaining data consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses cache invalidation on data modification and for user-specific manifest files. The change to no-cache for the manifest endpoint is correct. The addition of cache invalidation logic in store_user_data and delete_token is also the right approach. However, the error handling for cache invalidation can be improved. Currently, exceptions are either swallowed silently or logged without the original exception's context, which can hide bugs. My review includes suggestions to make the error handling more robust by logging exceptions properly.

[TimilsinaBimal]

/gemini review

[gemini-code-assist]

Code Review

This pull request addresses cache invalidation issues by disabling client-side caching for the dynamic user manifest and adding cache invalidation logic to store_user_data and delete_token methods. The changes are logical and directly address the problem of stale data. My review includes suggestions to refine the exception handling in the new cache invalidation logic to avoid performance degradation and unnecessary logging when dealing with non-cached items, which is a normal operational scenario.