Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS18B20 Temp Sensor #19

Closed
baker12 opened this issue Jul 25, 2018 · 4 comments
Closed

DS18B20 Temp Sensor #19

baker12 opened this issue Jul 25, 2018 · 4 comments

Comments

@baker12
Copy link

baker12 commented Jul 25, 2018

Is this sensor now supported native in TinkerOS? I have the latest (2.0.7) installed and have enabled 1-Wire through the Config tool but I still do not see my device. Didn't know if I needed to compile any drivers or not.

@jamess-huang
Copy link
Contributor

Hi,
It supported in the native TinkerOS. Please reference the below link.
https://tinkerboarding.co.uk/wiki/index.php/DS18B20

@baker12
Copy link
Author

baker12 commented Jul 25, 2018

Alright. I had saw that before and was confused if I needed to do that myself or not, but saw in the source code on here that it was all in there. I'll do some more checking and see why the sensor isn't showing up. Thanks!

@jamess-huang
Copy link
Contributor

jamess-huang commented Jul 25, 2018

Hi,
At the v2.0.7, you do not recompile kernel but if you want to change the default GPIO, then you need recompile kernel. Suppose you want to use the default GPIO, you just need do the section 3.1 of the below link.
https://tinkerboarding.co.uk/wiki/index.php/1-wire .

@baker12
Copy link
Author

baker12 commented Jul 25, 2018

Figured out I was reading the wrong GPIO 17 (Read the number on the Pi-Cobbler I'm using and miscounted from the figure). Everything is working good now!

jamess-huang pushed a commit that referenced this issue Nov 16, 2018
commit a04f0017c22453613d5f423326b190c61e3b4f98 upstream.

A spinlock is held while updating the internal copy of the IRQ mask,
but not while writing it to the actual IMASK register. After the lock
is released, an IRQ can occur before the IMASK register is written.
If handling this IRQ causes the mask to be changed, when the handler
returns back to the middle of the first mask update, a stale value
will be written to the mask register.

If this causes an IRQ to become unmasked that cannot have its status
cleared by writing a 1 to it in the IREG register, e.g. the SDIO IRQ,
then we can end up stuck with the same IRQ repeatedly being fired but
not handled. Normally the MMC IRQ handler attempts to clear any
unexpected IRQs by writing IREG, but for those that cannot be cleared
in this way then the IRQ will just repeatedly fire.

This was resulting in lockups after a while of using Wi-Fi on the
CI20 (GitHub issue #19).

Resolve by holding the spinlock until after the IMASK register has
been updated.

Cc: stable@vger.kernel.org
Link: MIPS/CI20_linux#19
Fixes: 61bfbdb ("MMC: Add support for the controller on JZ4740 SoCs.")
Tested-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Alex Smith <alex.smith@imgtec.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bauuuuu pushed a commit to Bauuuuu/debian_kernel that referenced this issue Dec 5, 2018
[ Upstream commit 2bbea6e117357d17842114c65e9a9cf2d13ae8a3 ]

when mounting an ISO filesystem sometimes (very rarely)
the system hangs because of a race condition between two tasks.

PID: 6766   TASK: ffff88007b2a6dd0  CPU: 0   COMMAND: "mount"
 #0 [ffff880078447ae0] __schedule at ffffffff8168d605
 TinkerBoard#1 [ffff880078447b48] schedule_preempt_disabled at ffffffff8168ed49
 TinkerBoard#2 [ffff880078447b58] __mutex_lock_slowpath at ffffffff8168c995
 TinkerBoard#3 [ffff880078447bb8] mutex_lock at ffffffff8168bdef
 TinkerBoard#4 [ffff880078447bd0] sr_block_ioctl at ffffffffa00b6818 [sr_mod]
 TinkerBoard#5 [ffff880078447c10] blkdev_ioctl at ffffffff812fea50
 TinkerBoard#6 [ffff880078447c70] ioctl_by_bdev at ffffffff8123a8b3
 TinkerBoard#7 [ffff880078447c90] isofs_fill_super at ffffffffa04fb1e1 [isofs]
 TinkerBoard#8 [ffff880078447da8] mount_bdev at ffffffff81202570
 TinkerBoard#9 [ffff880078447e18] isofs_mount at ffffffffa04f9828 [isofs]
TinkerBoard#10 [ffff880078447e28] mount_fs at ffffffff81202d09
TinkerBoard#11 [ffff880078447e70] vfs_kern_mount at ffffffff8121ea8f
TinkerBoard#12 [ffff880078447ea8] do_mount at ffffffff81220fee
TinkerBoard#13 [ffff880078447f28] sys_mount at ffffffff812218d6
TinkerBoard#14 [ffff880078447f80] system_call_fastpath at ffffffff81698c49
    RIP: 00007fd9ea914e9a  RSP: 00007ffd5d9bf648  RFLAGS: 00010246
    RAX: 00000000000000a5  RBX: ffffffff81698c49  RCX: 0000000000000010
    RDX: 00007fd9ec2bc210  RSI: 00007fd9ec2bc290  RDI: 00007fd9ec2bcf30
    RBP: 0000000000000000   R8: 0000000000000000   R9: 0000000000000010
    R10: 00000000c0ed0001  R11: 0000000000000206  R12: 00007fd9ec2bc040
    R13: 00007fd9eb6b2380  R14: 00007fd9ec2bc210  R15: 00007fd9ec2bcf30
    ORIG_RAX: 00000000000000a5  CS: 0033  SS: 002b

This task was trying to mount the cdrom.  It allocated and configured a
super_block struct and owned the write-lock for the super_block->s_umount
rwsem. While exclusively owning the s_umount lock, it called
sr_block_ioctl and waited to acquire the global sr_mutex lock.

PID: 6785   TASK: ffff880078720fb0  CPU: 0   COMMAND: "systemd-udevd"
 #0 [ffff880078417898] __schedule at ffffffff8168d605
 TinkerBoard#1 [ffff880078417900] schedule at ffffffff8168dc59
 TinkerBoard#2 [ffff880078417910] rwsem_down_read_failed at ffffffff8168f605
 TinkerBoard#3 [ffff880078417980] call_rwsem_down_read_failed at ffffffff81328838
 TinkerBoard#4 [ffff8800784179d0] down_read at ffffffff8168cde0
 TinkerBoard#5 [ffff8800784179e8] get_super at ffffffff81201cc7
 TinkerBoard#6 [ffff880078417a10] __invalidate_device at ffffffff8123a8de
 TinkerBoard#7 [ffff880078417a40] flush_disk at ffffffff8123a94b
 TinkerBoard#8 [ffff880078417a88] check_disk_change at ffffffff8123ab50
 TinkerBoard#9 [ffff880078417ab0] cdrom_open at ffffffffa00a29e1 [cdrom]
TinkerBoard#10 [ffff880078417b68] sr_block_open at ffffffffa00b6f9b [sr_mod]
TinkerBoard#11 [ffff880078417b98] __blkdev_get at ffffffff8123ba86
TinkerBoard#12 [ffff880078417bf0] blkdev_get at ffffffff8123bd65
TinkerBoard#13 [ffff880078417c78] blkdev_open at ffffffff8123bf9b
TinkerBoard#14 [ffff880078417c90] do_dentry_open at ffffffff811fc7f7
TinkerBoard#15 [ffff880078417cd8] vfs_open at ffffffff811fc9cf
TinkerBoard#16 [ffff880078417d00] do_last at ffffffff8120d53d
TinkerBoard#17 [ffff880078417db0] path_openat at ffffffff8120e6b2
TinkerBoard#18 [ffff880078417e48] do_filp_open at ffffffff8121082b
TinkerBoard#19 [ffff880078417f18] do_sys_open at ffffffff811fdd33
TinkerBoard#20 [ffff880078417f70] sys_open at ffffffff811fde4e
TinkerBoard#21 [ffff880078417f80] system_call_fastpath at ffffffff81698c49
    RIP: 00007f29438b0c20  RSP: 00007ffc76624b78  RFLAGS: 00010246
    RAX: 0000000000000002  RBX: ffffffff81698c49  RCX: 0000000000000000
    RDX: 00007f2944a5fa70  RSI: 00000000000a0800  RDI: 00007f2944a5fa70
    RBP: 00007f2944a5f540   R8: 0000000000000000   R9: 0000000000000020
    R10: 00007f2943614c40  R11: 0000000000000246  R12: ffffffff811fde4e
    R13: ffff880078417f78  R14: 000000000000000c  R15: 00007f2944a4b010
    ORIG_RAX: 0000000000000002  CS: 0033  SS: 002b

This task tried to open the cdrom device, the sr_block_open function
acquired the global sr_mutex lock. The call to check_disk_change()
then saw an event flag indicating a possible media change and tried
to flush any cached data for the device.
As part of the flush, it tried to acquire the super_block->s_umount
lock associated with the cdrom device.
This was the same super_block as created and locked by the previous task.

The first task acquires the s_umount lock and then the sr_mutex_lock;
the second task acquires the sr_mutex_lock and then the s_umount lock.

This patch fixes the issue by moving check_disk_change() out of
cdrom_open() and let the caller take care of it.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants