Issue #54 - Addition of support for sending binary data (Android only) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Implemented for Android only) Interface is: sendBinary(successCallback, errorCallback, connectionId, data) data is a JSONArray, one element per byte, e.g. [ 0x00, 0x01, 0x00, 0xFD ]
|
Thanks for your PR @shblythe, we're looking forward to include this ASAP. |
|
I've implemented binary support for ios as well in my fork of @shblythe's repo: https://github.com/mershon-enterprises/cdv-socket-plugin/tree/feature-ios-binary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a submission for inclusion to resolve issue #54.
It also provides and interface for issue #53, but no implementation for any platform other than Android.
I've added a new function, sendBinary, as I proposed in issue #54, and documented this in README.md.
I have done basic sanity testing, and it works, but I haven't tested all exception cases.