Feature/issue 305 #339
Merged
Feature/issue 305 #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange added multi-line functionality and a larger textbox size.
…press now reflects the changes made in the codebase for proper testing.
|
Great work! |
Caleb-Cohen
added a commit
that referenced
this pull request
Feb 18, 2023
* Added testing to pull request template * Feature/issue 314 (#319) * Install Cypress & needed packages Update eslint config Update gitignore Add testing development mongo path * Add nock Passport.js Discord request interception * Add Cypress tests * Disable server logging when testing * Fix delay-toggling environment variable Cypress wasn't properly listening to the CYPRESS_NO_DELAYS environment variable to disable the animations waits * added modulus to getHoursAndMinutes --------- Co-authored-by: Caleb Cohen <CalebCohen@hotmail.com> * starting workflow for actions * typo within review pull request * add environment dev to workflow * workflow changes * lint fixes (#324) * Actions timeout (#326) * Add timeout to GitHub actions GitHub action workflows should be limited so minutes aren't wasted if it hangs and bugs can be caught earlier. If 30 minutes isn't enough, it can be increased later on * change timeout to 10 minutes * Modified app metadata to "Together is a scheduling and collaboration … (#325) * Modified app metadata to "Together is a scheduling and collaboration tool built for and by 100Devs community for creating, discovering and keeping track of events on discord." * Deleted the extra space. * Server tests. #288 (#289) * install jest and supertest * separate app and server into different files * add jest coverage folder to gitignore * allow the use of mock user in test environment * change validateBody to be a sync function * add 'use strict', fix variable declarations * extract constants * remove console logs * add mock user to db * refactor, fix validation bugs in createEventSchema * test httpError * test validateObjectId * test validateBody * refactor unit tests * export STRING_MAX_LENGTH to be used in tests * fix dotenv path to work in tests * modify mock request * test routes * refactor maxEvents middleware * add tests for maxEvents * allow event end time (not date) to be before start time * test create event with valid data * timezone bug fix: add offset to days * test createEventArray * create date range with Date instead of datefns lib * test createEventsArray in JST timezone * refactor createEventsArray and tests * fix test JST time * use Temporal to work with dates * fix event duration using Temporal * test cases for createEventsArray * test validateBody * fix acceptance tests * change hardcoded timezone to machine timezone * update test script * remove irrelevant test (maxEvents) * update front-end test * add script to run all tests together * add route tests * added formidable, jsbi, moved jest and supertest to dev dependencies --------- Co-authored-by: Caleb Cohen <CalebCohen@hotmail.com> * Fix guest modal and and updated test (#327) * Fix guest modal and and updated test * author changes and lint fix * Make time-asserting code locale-based --------- Co-authored-by: Rascal_Two <therealrascaltwo@gmail.com> * Removed delete all button from non-recurring events (#332) * Removed delete all button from non-recurring events * Removed console.log from file * Feature/issue 305 (#339) * changed description section input element to textarea element. This change added multi-line functionality and a larger textbox size. * In the input object, I changed the input element text to textarea. Cypress now reflects the changes made in the codebase for proper testing. * Created a close button, in UserForm.js (#333) --------- Co-authored-by: Rascal Two <therealrascaltwo@gmail.com> Co-authored-by: Jacob Asper <jacobasper191@gmail.com> Co-authored-by: uaravindshenoy <75222342+uaravindshenoy@users.noreply.github.com> Co-authored-by: Roman Stetsyk <25715951+romanstetsyk@users.noreply.github.com> Co-authored-by: Lalysi <75863568+lalysi@users.noreply.github.com> Co-authored-by: Mike Jakuszewski <114702999+MikeJakuszewski@users.noreply.github.com> Co-authored-by: Jae Salaski <hello@jsalaski.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was tasked with making the description field in the add event form larger. I made the decision to change the codebase from an input element to a textarea element. The reason is that the textarea element allows for multi-line text whereas the input element is more designed for single-line entries. With this change, the default text area is now larger, it is dynamic and can be changed in size, and text can now be written on multiple lines.
I also had to update the cypress testing from input in the input object to textarea for proper testing. After this change was made, no errors were found.
Closes #305
Type of change
Issue
Checklist:
npm run test-frontendand all tests have passed successfully or I have included details within my PR on the failurenpm run lintand resolved any outstanding errors. Most issues can be solved by executingnpm run format