Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.3 #340

Merged
merged 14 commits into from
Feb 18, 2023
Merged

Release 1.1.3 #340

merged 14 commits into from
Feb 18, 2023

Conversation

Caleb-Cohen
Copy link
Member

@Caleb-Cohen Caleb-Cohen commented Feb 18, 2023

Description

Update includes:

  • Adding testing to pull request
  • Added E2E testing by @RascalTwo
  • starting workflow for actions
  • some linting updates
  • actions timeout by @20jasper
  • Modifying the metadata by @uaravindshenoy
  • Server tests by @romanstetsyk
  • Guest modal for event view and updated test by @RascalTwo and @Caleb-Cohen
  • Removed delete all button for non-recurring events by @lalysi
  • adding larger description size by @MikeJakuszewski
  • Created close button for userform @jsalaski

Type of change

Please select everything applicable. Please, do not delete any lines.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires an update to testing

Issue

  • Is this related to a specific issue? If so, please specify:

Checklist:

  • This PR is up to date with the development branch, and merge conflicts have been resolved
  • I have executed npm run test-frontend and all tests have passed successfully or I have included details within my PR on the failure
  • I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Caleb-Cohen and others added 14 commits February 11, 2023 10:39
* Install Cypress & needed packages

Update eslint config
Update gitignore
Add testing development mongo path

* Add nock Passport.js Discord request interception

* Add Cypress tests

* Disable server logging when testing

* Fix delay-toggling environment variable

Cypress wasn't properly listening to the CYPRESS_NO_DELAYS environment variable to disable the animations waits

* added modulus to getHoursAndMinutes

---------

Co-authored-by: Caleb Cohen <CalebCohen@hotmail.com>
* Add timeout to GitHub actions

GitHub action workflows should be limited so minutes aren't wasted if it hangs and bugs can be caught earlier. If 30 minutes isn't enough, it can be increased later on

* change timeout to 10 minutes
#325)

* Modified app metadata to "Together is a scheduling and collaboration tool built for and  by 100Devs community for creating, discovering and keeping track of events on discord."

* Deleted the extra space.
* install jest and supertest

* separate app and server into different files

* add jest coverage folder to gitignore

* allow the use of mock user in test environment

* change validateBody to be a sync function

* add 'use strict', fix variable declarations

* extract constants

* remove console logs

* add mock user to db

* refactor, fix validation bugs in createEventSchema

* test httpError

* test validateObjectId

* test validateBody

* refactor unit tests

* export STRING_MAX_LENGTH to be used in tests

* fix dotenv path to work in tests

* modify mock request

* test routes

* refactor maxEvents middleware

* add tests for maxEvents

* allow event end time (not date) to be before start time

* test create event with valid data

* timezone bug fix: add offset to days

* test createEventArray

* create date range with Date  instead of datefns lib

* test createEventsArray in JST timezone

* refactor createEventsArray and tests

* fix test JST time

* use Temporal to work with dates

* fix event duration using Temporal

* test cases for createEventsArray

* test validateBody

* fix acceptance tests

* change hardcoded timezone to machine timezone

* update test script

* remove irrelevant test (maxEvents)

* update front-end test

* add script to run all tests together

* add route tests

* added formidable, jsbi, moved jest and supertest to dev dependencies

---------

Co-authored-by: Caleb Cohen <CalebCohen@hotmail.com>
* Fix guest modal and and updated test

* author changes and lint fix

* Make time-asserting code locale-based

---------

Co-authored-by: Rascal_Two <therealrascaltwo@gmail.com>
* Removed delete all button from non-recurring events

* Removed console.log from file
* changed description section input element to textarea element. This change added multi-line functionality and a larger textbox size.

* In the input object, I changed the input element text to textarea. Cypress now reflects the changes made in the codebase for proper testing.
@Caleb-Cohen Caleb-Cohen temporarily deployed to DEV February 18, 2023 19:45 — with GitHub Actions Inactive
@Caleb-Cohen Caleb-Cohen marked this pull request as ready for review February 18, 2023 19:50
@Caleb-Cohen Caleb-Cohen merged commit f22f80d into main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants