Generation of logger inside methods

[java-coding-prodigy]

Describe the bug
DatabaseProvider generates new loggers inside its methods

Expected behavior
The logger should be put into a private static field called logger

Additional context
Occurences:

1. line 37

catch (final SQLException e) {
            LoggerFactory.getLogger(DatabaseProvider.class)
                .error("Exception while creating Database.", e);
            throw new FatalBeanException("Could not create Database.", e);
        }

2. line 49

catch (final IOException e) {
            LoggerFactory.getLogger(DatabaseProvider.class)
                .error("Exception while creating Database-Path.", e);
        }

[krankkkk]

That is not how loggers work, there is no need for the field

[Tais993]

It is the typical usage pattern, therefore I'd disagree

[java-coding-prodigy]

there is no need for the field

I disagree with this too.

[krankkkk]

1. The loggers would only be created on a fatal exception, which means the application cannot continue. The change to an field would actually just create an unused logger.
2. Even if you would somehow end up calling those lines multiple times, you would not create new loggers, they are cached in slf4j/log4j

[java-coding-prodigy]

I see your point, but to maintain the pattern with other classes and also making the code more readable, this change should be made.

[Tais993]

1, that's fine
2, I know

Why should we change it?

1, consistency

The typical usage pattern is to use a field, it's consistent around our codebase, and everyone's else's codebase. Changing it won't do any harm

[krankkkk]

Then this is still not a bug, mark it as improvement

[apwhitelaw]

Is this what you mean?

private static final Logger logger = LoggerFactory.getLogger(DatabaseProvider.class);

at the top of the class, and then update the two places where we log the error to instead use that field, like so:

logger.error("Exception while creating Database.", e);

If that's correct, I can go ahead and implement it.