Added logger field

[java-coding-prodigy]

Fixes #365

[krankkkk]

As said in the ticket, no reason for the field. So I would close this

[marko-radosavljevic]

I like consistency, so the changes make sense to me. Please check if there is any other place in the codebase where similar thing occurs, so we can align.

I will temporarily put a hold on this PR, because code owner (@krankkkk) disagrees with the changes. ^^

[java-coding-prodigy]

Please check if there is any other place in the codebase where similar thing occurs, so we can align.

If I find something will I add that to this PR itself, or another one?

[Tais993]

This PR is fine

[java-coding-prodigy]

SonarLint is unhappy that SpringBootServletInitializer(super class of Application in logviewer) has a protected field with the name logger. What do we do about this?

[Tais993]

Time to remove sonarlint since it's giving me mental issues

All loggers should be private, so change that

[java-coding-prodigy]

All loggers should be private, so change that

Um, I cannot do that, it is a class from Spring that is causing this issue. Note that the logger there is of class org.apache.commons.logging.Log and not an SLF4J logger

[Tais993]

Rename our logger to log ig?

Just Sonarlint being stupid again

[java-coding-prodigy]

Just Sonarlint being stupid again

I could suppress that warning, imo that would be better.

[Tais993]

Then I'd do that

seems like we agreed on how to proceed with this ^^

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication