Skip to content

Remove "/role-select all" #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zabuzard opened this issue Feb 15, 2022 · 2 comments · Fixed by #389
Closed

Remove "/role-select all" #381

Zabuzard opened this issue Feb 15, 2022 · 2 comments · Fixed by #389
Assignees
Labels
discussion enhance command Modify or improve an existing command or group of commands of the bot good first issue Good for newcomers priority: normal

Comments

@Zabuzard
Copy link
Member

Recently, we merged #351 and it is pretty cool. However, it has two subcommands:

  • /role-select all - users can pick any of the existing roles on the server
  • /role-select choose - users can only pick roles that the mod pre-selected

I do not see a valid use case for /role-select all. Why would you want people to give the possibility to choose from ALL roles (including staff assistant, moderator, ... and other dangerous roles).

In fact, it only takes a careless mod to accidentally run /role-select all, hit enter and oops people could already give themselves Moderator, Staff Assistant and other "protected" roles (and you wouldnt even notice).

I propose to remove /role-select all and lift /role-select choose to just /role-select.

@Zabuzard Zabuzard added discussion enhance command Modify or improve an existing command or group of commands of the bot priority: normal labels Feb 15, 2022
@Zabuzard Zabuzard added this to the Migrate existing commands milestone Feb 15, 2022
@Zabuzard
Copy link
Member Author

(@Tais993 for visibility)

@Tais993
Copy link
Member

Tais993 commented Feb 15, 2022

I agree, kept it since it was in the original implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhance command Modify or improve an existing command or group of commands of the bot good first issue Good for newcomers priority: normal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants