Reaction roles using a SelectionMenu #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tais993
added
new command
Tais993
force-pushed
the
feature/migrate_reaction_roles
branch
2 times, most recently
from
df6e067 to
7534a15
Compare
java-coding-prodigy
previously requested changes
Jan 24, 2022
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
|
Can't test due to DB issues, so back to a draft for now |
|
Added screenshots for UX ^^ |
Tais993
force-pushed
the
feature/migrate_reaction_roles
branch
from
ca58c5c to
2ce80eb
Compare
Heatmanofurioso
requested changes
Jan 25, 2022
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
Tais993
commented
Jan 25, 2022
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
Heatmanofurioso
previously approved these changes
Jan 25, 2022
Tais993
force-pushed
the
feature/migrate_reaction_roles
branch
from
3261ef4 to
d4ca130
Compare
Tais993
dismissed
java-coding-prodigy’s stale review
no-one cares enough, so it'll stay like that
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Show resolved
Hide resolved
DUDE I THOUGHT, ITS SUCH A TINY CHANCE, NO WAY ILL FUCK UP SPOTLESS. THEN I DO? ARE YOU SERIOUS? IATRHAWGRTUSEGTH Se UIRSE
Tais993
force-pushed
the
feature/migrate_reaction_roles
branch
from
6f61484 to
958f9cc
Compare
|
This PR has been stale for 10 days, could anyone review please? |
Zabuzard
requested changes
Feb 7, 2022
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
Comment on lines
+203
to
+204
|
|
||
|
|
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Zabuzard
approved these changes
Feb 8, 2022
Tais993
requested review from
AzatothTheAwakened,
Budbomber,
d3vel0per,
Doppeey,
I-Al-Istannen,
illuminator3,
DevSerendipity,
JJeeff248,
krankkkk,
LovinLifee,
marko-radosavljevic and
a team
Heatmanofurioso
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the reaction roles, this is based of the original PR by JJeff248, see #284
At the moment of writing
UX:
Slash-command
When running the choose or all command, you get asked for what the embed's title and description has to be.
Choose sub-command
When running the choose command, it displays the embed you gave, and it allows you to select roles.
After selecting the roles, it sends a message with a SelectionMenu for the roles.
Role selection by user
After this, the UX is the same for choosing the roles yourself or just picking all roles.
Once you select the roles, it sends a message saying your roles have been "updated"
Notes
Emoji roleicon support has been added, emotes support unfortunately can't be added (to my knowledge). Can't test due to not having a level 2 server
For in the future when modals / forms get released, we might want to make it a modal so we can add a description and such. But that won't be this PR most likely