Fix union-type handling in PublicPropertyFetchCollector (#120)

* Fix union-type handling in public-properties

* simplify

src/Collectors/PublicPropertyFetchCollector.php

@@ -53,19 +53,18 @@ public function processNode(Node $node, Scope $scope): ?array
             return null;
         }
 
-        $propertyFetcherType = $scope->getType($node->var);
-        if (! $propertyFetcherType instanceof TypeWithClassName) {
-            return null;
-        }
-
         $classReflection = $scope->getClassReflection();
         if ($classReflection instanceof ClassReflection && $this->classTypeDetector->isTestClass($classReflection)) {
             return null;
         }
 
-        $className = $propertyFetcherType->getClassName();
-        $propertyName = $node->name->toString();
+        $result = [];
+        $propertyFetcherType = $scope->getType($node->var);
+        foreach($propertyFetcherType->getObjectClassReflections() as $classReflection) {
+            $propertyName = $node->name->toString();
+            $result[] = $classReflection->getName() . '::' . $propertyName;
+        }
 
-        return [$className . '::' . $propertyName];
+        return $result;
     }
 }

tests/Rules/UnusedPublicPropertyRule/Fixture/UsedInUnionA.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture;
+
+class UsedInUnionA {
+    public float $amount;
+}

tests/Rules/UnusedPublicPropertyRule/Fixture/UsedInUnionB.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture;
+
+class UsedInUnionB {
+    public float $amount;
+}

tests/Rules/UnusedPublicPropertyRule/Source/UsedInUnion.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Source;
+
+use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture\UsedInUnionA;
+use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture\UsedInUnionB;
+
+function doFooBar(UsedInUnionA|UsedInUnionB $aOrB): void {
+    echo $aOrB->amount;
+}
+

tests/Rules/UnusedPublicPropertyRule/Source/UsedInUnionPhpdoc.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Source;
+
+use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture\UsedInUnionA;
+use TomasVotruba\UnusedPublic\Tests\Rules\UnusedPublicPropertyRule\Fixture\UsedInUnionB;
+
+/** @param UsedInUnionA|UsedInUnionB $aOrB */
+function doFoo($aOrB): void {
+    echo $aOrB->amount;
+}

tests/Rules/UnusedPublicPropertyRule/UnusedPublicPropertyRuleTest.php

@@ -109,6 +109,10 @@ public static function provideData(): Iterator
             ],
             [],
         ];
+
+        yield [[__DIR__ . '/Fixture/UsedInUnionA.php', __DIR__ . '/Fixture/UsedInUnionB.php', __DIR__ . '/Source/UsedInUnion.php'], []];
+        yield [[__DIR__ . '/Fixture/UsedInUnionA.php', __DIR__ . '/Fixture/UsedInUnionB.php', __DIR__ . '/Source/UsedInUnionPhpdoc.php'], []];
+
     }
 
     /**