Fix union-type handling in PublicPropertyFetchCollector

[staabm]

closes #119

[staabm]

btw: IMO as someone used to the 1-file test-cases from the phpstan-src repo, this separation of classes over several files (fixture + source) makes creating unit tests pretty hard and unnecessary complex

[TomasVotruba]

What do you suggest?

[staabm]

I would put all classes for a single test-case into a single file (with a unique namespace) and use composer class-map autoloading for tests instead of psr-4.

see https://github.com/phpstan/phpstan-src/blob/89636d6983c73687a9c6d50deac0b01158291f59/composer.json#L133-L136

but not in this PR of course.. it fixes a problem unrelated to this file-system design thing ;)

[TomasVotruba]

I see. For the /Source it made mess as people used same-named classes: )

[staabm]

for the PR we have here, that would mean the test-case file would look like:

namespace Bug119;

class UsedInUnionA {
    public float $amount;
}

class UsedInUnionB {
    public float $amount;
}

function doFooBar(UsedInUnionA|UsedInUnionB $aOrB): void {
    echo $aOrB->amount;
}

• no separation in fixture/source
• no complicated file path mapping in the *RuleTest.php
• easier handling, because a test-case can be deleted with a single file (no dependencies outside the test-file)

[staabm]

same-named classes: )

therefore a dedicated namespace for each test.

[staabm]

in phpstan-src there is a CI check to make sure class-names are unique - shipmonk/name-collision-detector

[TomasVotruba]

therefore a dedicated namespace for each test.

That's the place people failed :) we had dozens such cases in Rector, often easy to miss in IDE.

[TomasVotruba]

Looks good, thanks 👍

[staabm]

Looks good, thanks

thanks. I prepare another PR with the same fix for static properties