-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reader and writer for NXTomo files #939
Draft
lauramurgatroyd
wants to merge
12
commits into
master
Choose a base branch
from
nxtomo-read-write
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do:
|
This was referenced Oct 1, 2021
base class #1020 |
casperdcl
force-pushed
the
master
branch
3 times, most recently
from
September 2, 2024 13:11
a910556
to
f8b513b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to read and write the NXTomo format.
Reader was modified from this code
Writer makes use of this code
Addresses the first part of #744
I copied over all methods from the original reader code, but I am unsure whether the following are needed:
get_acquisition_data_subset
,get_acquisition_data_batch
andget_acquisition_data_subset
- the same thing can be achieved by using slicing withget_acquisition_data
if thedimensions
are set.get_acquisition_data_whole
- the same thing is returned if you just useget_acquisition_data
withoutdimensions
setFrom the NXTomo documentation, the data is of shape [nFrames, xSize, ySize], however in the previous code and by visualising NXTomo datasets from EPAC, it is seen that the data is in the order (angles, vertical, horizontal), which is the default for CIL acquisition data.
Another point is I am wondering if we should have some way for the user to specify which integer type they would like to write to the file. By default the NEXUSDataWriter writes out as float32 but the NXTomo format expects the data as "any representation of an integer number". I have set it to uint32, but say for example I have a uint16 dataset that I read in and want to write out again then it will double in size!