src: fix localtime in case NaN is passed #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check for the validity of the argument in JS-land. - The test localtime() in exports.js was failing because struct tm *timeinfo in NAN_METHOD(Localtime) was being created correctly.
|
@TooTallNate Any chance this could be merged and released? It’s been a couple years… :) |
targos
added a commit
to targos/citgm
that referenced
this pull request
Dec 15, 2018
Waiting for the fix to land and be in a release. Refs: TooTallNate/node-time#76
targos
added a commit
to nodejs/citgm
that referenced
this pull request
Dec 15, 2018
Waiting for the fix to land and be in a release. Refs: TooTallNate/node-time#76
9 tasks
|
Ping @TooTallNate PTAL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAN_METHOD(Localtime) was being created correctly.