Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: skip time on >=11 #657

Merged
merged 1 commit into from
Dec 15, 2018
Merged

lookup: skip time on >=11 #657

merged 1 commit into from
Dec 15, 2018

Conversation

targos
Copy link
Member

@targos targos commented Dec 15, 2018

Waiting for the fix to land and be in a release.

Refs: TooTallNate/node-time#76

Waiting for the fix to land and be in a release.

Refs: TooTallNate/node-time#76
@codecov-io
Copy link

codecov-io commented Dec 15, 2018

Codecov Report

Merging #657 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #657   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          26       26           
  Lines         823      823           
=======================================
  Hits          777      777           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3d2dc...66e7515. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos merged commit 00c3818 into nodejs:master Dec 15, 2018
@targos targos deleted the skip-time branch December 15, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants