fix: prefer docker-compose-v1 to work around race condition changes i…

…n Compose V2 RC3 (#304)

* fix: prefer docker-compose-v1 to work around race condition introduced by Compose V2 RC3

* fix: cache the composeCommand() call

* style nit

cmd/up.go

@@ -307,11 +307,12 @@ Examples:
 			log.Info("☐ performing preRun step for services")
 
 			for _, s := range selectedServices {
+				name := s.FullName()
 				if s.PreRun == "" {
+					log.Infof("\t☐ no preRun command for %s, continuing...\n", name)
 					continue
 				}
 
-				name := s.FullName()
 				log.Infof("\t☐ running preRun command %s for %s. this may take a long time.\n", s.PreRun, name)
 
 				err := docker.ComposeRun(s.DockerName(), s.PreRun)

docker/compose.go

@@ -2,6 +2,7 @@ package docker
 
 import (
 	"fmt"
+	"os/exec"
 	"strconv"
 	"strings"
 
@@ -15,14 +16,34 @@ const (
 	stopTimeoutSecs = 2
 )
 
+var composeCmd string
+
+func composeCommand() string {
+	if composeCmd != "" {
+		return composeCmd
+	}
+
+	_, err := exec.LookPath("docker-compose-v1")
+
+	if err == nil {
+		log.Debugf("docker-compose-v1 exists, using it to avoid race condition issue with Docker Compose version v2.0.0-rc.3...")
+		composeCmd = "docker-compose-v1"
+	} else {
+		log.Debugf("docker-compose-v1 does not exist, falling back to docker-compose (this might break if using Docker Compose version v2.0.0-rc.3)...")
+		composeCmd = "docker-compose"
+	}
+
+	return composeCmd
+}
+
 func composeFile() string {
 	return fmt.Sprintf("%s/docker-compose.yml", config.TBRootPath())
 }
 
 func ComposeExec(serviceName string, execArgs []string, cmd *command.Command) error {
 	args := []string{"-f", composeFile(), "exec", serviceName}
 	args = append(args, execArgs...)
-	err := cmd.Exec("docker-compose", args...)
+	err := cmd.Exec(composeCommand(), args...)
 	if err != nil {
 		return errors.Wrap(err, "failed to run docker-compose exec")
 	}
@@ -32,7 +53,7 @@ func ComposeExec(serviceName string, execArgs []string, cmd *command.Command) er
 func ComposeLogs(services []string, cmd *command.Command) error {
 	args := []string{"-f", composeFile(), "logs", "-f"}
 	args = append(args, services...)
-	err := cmd.Exec("docker-compose", args...)
+	err := cmd.Exec(composeCommand(), args...)
 	if err != nil {
 		return errors.Wrap(err, "failed to run docker-compose logs")
 	}
@@ -69,7 +90,7 @@ func execDockerCompose(subcmd string, args ...string) error {
 	defer w.Close()
 	cmd := command.New(command.WithStdout(w), command.WithStderr(w))
 	args = append([]string{"-f", composeFile(), subcmd}, args...)
-	err := cmd.Exec("docker-compose", args...)
+	err := cmd.Exec(composeCommand(), args...)
 	if err != nil {
 		return errors.Wrapf(err, "failed to run docker-compose %s", subcmd)
 	}