fix: prefer docker-compose-v1 to work around race condition changes in Compose V2 RC3 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by Compose V2 RC3
cszatmary
reviewed
Sep 16, 2021
| @@ -15,14 +16,25 @@ const ( | |||
| stopTimeoutSecs = 2 | |||
| ) | |||
|
|
|||
| func composeCommand() string { | |||
There was a problem hiding this comment.
I feel like we should cache the result vs looking it up every time so a single run is consistent (and doesn't produce these logs multiple times)
cszatmary
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack context: https://touchbistro.slack.com/archives/CU7JQ7ZPS/p1631815389225500
After upgrading to Docker for Mac 4.0.1, it appears something changed in Docker Compose V2 RC3 that causes some of our preRun scripts to fail with the following:
We have some fairly complex interdependencies with preRun scripts and we may have been depending on racy behaviour that was fixed.
This PR changes
tbto preferdocker-compose-v1which is still distributed as a binary with Docker for Mac (but for how long, who can tell).