Implement channel_uses_aux() (Fixes issue #29) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define when a channel needs to use aux LEDs as part of its operation, allowing that channel to block RGB voltage when on if configured.
SiteRelEnby
force-pushed
the
issue29-channel-uses-aux
branch
from
efb131c
to
cbef5e7
Compare
|
werks great for me, thanks. looks like pull request are not going to be merged though. |
|
Not going to be merged why? |
i dont know. |
|
So @gretel if pull requests doesn't get merged, how can I get the latest firmware from 2023-12-03 with this fix included? I am not able to complle it on my own 🫣 |
|
@diRk262 Which build targets do you need it for? I can build it. |
|
anduril-2023-12-30-channel-uses-aux.zip |
I updated my TS11 with this version. The rgb as multichannel is now working without getting overwritten by the voltage rgb function. |
|
@SiteRelEnby the workflow can build binaries (artifacts) if you approve it to run. |
|
@gretel Need to be a maintainer though. Although I guess could have on my fork. Ah well, it's 2 commands to run manually anyway. |
oh sorry, nothing i can do about that. |
Thank you for this. But in the TS11, it broke batt check when using the aux. Main and green channels can still blink the voltage but the rest of the colors just remain solid. I also have a TS25 if you need me to test on it. |
This prevents a user from 3Cing into an aux channel while in one of these strobes (candle mode and bike flasher) where they will just get solid aux as a result, while still allowing aux channels to be used for strobes where it might make sense (e.g. lightning, tac strobe). Also added uses_aux to the TS10v1 aux channel which I forgot before.
Sorry, missed this comment. I'll take a look. There's no fundamental config differences between the TS11 and TS25 that would matter. |
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
|
@zaziboo should be fixed now. |
set_level_zero was causing aux-based channels to be set to off at level 0 (i.e. level 1). Also added a clarifying comment.
SiteRelEnby
force-pushed
the
issue29-channel-uses-aux
branch
from
e97e9a0
to
532cf4a
Compare
|
Awesome! Thank you. But, unfortunately, I have no way to build hex's for now. Any chance you have the updated fixes hosted somewhere? |
stcarlso
pushed a commit
to stcarlso/anduril
that referenced
this pull request
Feb 17, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
stcarlso
pushed a commit
to stcarlso/anduril
that referenced
this pull request
Apr 25, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
The 0144 model number is reserved for the successor to the Meteor M44. This is Hank's first AA light, so it's assigned as 0161: - 01: Emisar - 6: product line 6 - 1: model 1
For 3V LEDs on a boost/buck dual fuel driver, this allows routing power around the boost converter in li-ion mode, to reduce resistance and increase maximum output. The AA/NiMH mode is unaffected, and boosts as normal.
to prevent corrupt data This was enabled on more build targets before, but the *_ENABLE_PIN definition names changed and the eeprom code didn't, so it was not compiled in for a few months on some lights which probably needed it. To fix that, it's now enabled by default on everything bigger than attiny85, since it doesn't really hurt anything if it's enabled when not needed.
(so 0 to 255 now goes from 0.00V to 5.10V)
Use case 1: Updating a t85 light, where tactical mode is useful but takes some squeezing, and momentary is less useful Use case 2: Custom builds for people who don't like/want momentary mode
Based on [SammysHP's patch](ToyKeeper#18), but only for lockout mode, not tactical.
Same as PL47G2 but with FET PWM levels safe for 219 emitters. Same as difference between PL47 and PL47-219. PL47G2 base allows low mode for aux LEDs, PL47 does not.
MCU space on a few lights
|
@zaziboo sorry, missed your comment. Just rebased it on the the latest changes, here's a zip if you want to test. |
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 14, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this pull request
Oct 16, 2024
First off, green was not defined properly and was instead defined the same as a main channel (leading to the behaviour described in the issue at ToyKeeper#33 (comment) Second, fix the actual bug causing aux to not work for blinky modes. Specifically, set_level needs to be patched so that instead of (or as well as, doesn't really matter) calling set_level_zero(), it will also check for if the active channel is an RGB channel and if so them clear RGB state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define when a channel needs to use aux LEDs as part of its operation, allowing that channel to block RGB voltage when on if configured.
Fixes: #29