Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to hardcoded outdated module versions; remove old repositories #11

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

hndmrsh
Copy link
Contributor

@hndmrsh hndmrsh commented Jun 13, 2022

The current version (1.0.1) has some hardcoded references to the 1.0.0 of some modules, which prevent projects from syncing exclusively from mavenCentral (as 1.0.0 is only available in jcenter). To fix this, I've replaced these references with $project.ext.version to ensure all modules are always built and published in sync.

I've also removed some old (dead) repos from the buildscripts!

Please let me know when you release this as 1.0.2 so I can remove jcenter from my projects 😄

Cheers!

@hndmrsh
Copy link
Contributor Author

hndmrsh commented Jun 26, 2022

Hey @rwjc! Any chance this will get merged in the near future? 🙏

@rwjc
Copy link
Contributor

rwjc commented Jun 28, 2022

Thanks @hndmrsh! Sorry for the delay. Patch looks good.

One last thing. Could you update the version to 1.0.2 before we merge this? Thanks!

@hndmrsh
Copy link
Contributor Author

hndmrsh commented Jun 28, 2022

Thanks @hndmrsh! Sorry for the delay. Patch looks good.

One last thing. Could you update the version to 1.0.2 before we merge this? Thanks!

Sweet – done!

@rwjc rwjc merged commit eb9e553 into TradeMe:master Jun 29, 2022
@rwjc rwjc mentioned this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants