Fix dependency versioning #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2022 19:57
Can't use version that hasn't been published yet. This is further complicated by current 1.0.1 version on MavenCentral [1] has a dependency on 1.0.0 of `nz.co.trademe.plunge:plunge-parsing` which only existed in jcenter. Once we've bootstrapped a new version of that into MavenCentral then we can get rid of the jcenter repo. [1] https://search.maven.org/artifact/nz.co.trademe.plunge/plunge-gradle-plugin/1.0.1/jar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with publishing after merging #11.
(We really should have an action to check build before merging)
The dependencies were set up to use a version that does not exist in any repo.
plunge-gradle-plugin/build.gradle: change to depend on the local project insteadsample/build.gradle: change to depend on the latest version that exists on maven central, which itself has a dependency on 1.0.0 ofnz.co.trademe.plunge:plunge-parsing(this at the moment only exists on jcenter).