Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tailwind CSS Migration from @emotion/styled #525

Merged
merged 2 commits into from
Feb 21, 2022
Merged

feat: Tailwind CSS Migration from @emotion/styled #525

merged 2 commits into from
Feb 21, 2022

Conversation

osslgtm
Copy link
Contributor

@osslgtm osslgtm commented Feb 3, 2022

Summary

Migration from @emotion/styled to Tailwind CSS

Changes

Removed the use of styled, switched styling to Tailwind and to fit in to the design patterns in @tradetrust-ui-components

Issues

https://www.pivotaltracker.com/story/show/181055490

@osslgtm osslgtm mentioned this pull request Feb 3, 2022
Closed
simboonlong
simboonlong approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@simboonlong simboonlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simboonlong simboonlong mentioned this pull request Feb 16, 2022
Merged
@superical
Copy link
Contributor

@puayhiang Can we mark this PR as ready when it's done? Thanks!🙏

@osslgtm osslgtm marked this pull request as ready for review February 17, 2022 02:48
@osslgtm
Copy link
Contributor Author

osslgtm commented Feb 17, 2022

@superical Ok to merge ?

@superical
Copy link
Contributor

@puayhiang Thanks! I just tried to run the PR and the network selection component looks a little different from its original styling. Just to check, is this due to the limitation of Tailwind? Or is there something else that can be done to match their styles?

In this PR:
image

Original:
image

@osslgtm
Copy link
Contributor Author

osslgtm commented Feb 17, 2022 •
edited
Loading

It's made to look like the menu bar on the left, maybe i can check with Jerry on this ?

@superical
Copy link
Contributor

superical commented Feb 17, 2022 •
edited
Loading

Ahh… It’s intentional. I see. I initially thought it was due to some limitations. Okay sure, you can check to see if the design of the component is alright first. If so, then we can proceed with merging. Thanks!😊

PS: The next step after this is to move that network selector component down on the verify page based on the new design. So it will be easier in the next step once we get the design right.

@superical superical merged commit 9d9da2e into feat/multi-chain Feb 21, 2022
@superical superical deleted the feat/tailwindcss-migration branch February 21, 2022 08:08
@superical superical restored the feat/tailwindcss-migration branch February 21, 2022 08:15
@superical superical deleted the feat/tailwindcss-migration branch February 21, 2022 08:16
@superical
Copy link
Contributor

Sorry!! I accidentally merged into #506 after resolving a merge conflict forgetting that I was previously testing this PR.🤦‍♂️
I have reverted the merge. Will need to re-create another PR for this change.

@osslgtm osslgtm mentioned this pull request Feb 21, 2022
Merged
osslgtm added a commit that referenced this pull request Feb 23, 2022
@osslgtm
feat: Tailwind CSS Migration from @emotion/styled (#542, #525)
be3ce0d 
* feat: networkselect ui for verify

* Revert "Revert "feat: migrate to tailwindcss from styled""

This reverts commit 8420946.

* fix/tailwind v3 class migrations

* fix/rollback verify network selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simboonlong simboonlong simboonlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osslgtm @superical @simboonlong