Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tailwind CSS Migration from @emotion/styled #542

Merged
merged 7 commits into from
Feb 23, 2022

Conversation

osslgtm
Copy link
Contributor

@osslgtm osslgtm commented Feb 21, 2022

Summary

Migration from @emotion/styled to Tailwind CSS

Changes

Removed the use of styled, switched styling to Tailwind and to fit in to the design patterns in @tradetrust-ui-components

Issues

https://www.pivotaltracker.com/story/show/181055490

cont...
#525

@osslgtm osslgtm closed this Feb 21, 2022
@osslgtm osslgtm deleted the feat/tailwindcss-migration branch February 21, 2022 09:06
@osslgtm osslgtm restored the feat/tailwindcss-migration branch February 21, 2022 10:12
@osslgtm osslgtm reopened this Feb 21, 2022
@osslgtm osslgtm force-pushed the feat/tailwindcss-migration branch from c59ae48 to 606803a Compare February 21, 2022 10:37
@osslgtm
Copy link
Contributor Author

osslgtm commented Feb 22, 2022

Changes of Verify Dropdown Bar and Tailwind V3 Class Changes (Checked)

Previous changes are under #525

Verify Page
image
Mobile
image

@osslgtm osslgtm marked this pull request as ready for review February 22, 2022 05:50
@osslgtm osslgtm requested a review from superical February 22, 2022 05:51
@superical
Copy link
Contributor

@puayhiang Cool! Looks nice! Thanks a lot!😀 Do you think we can remove the network selector at the navigation bar too now that we have moved it down on the verify page? Based on the new design on figma, the network selector will no longer be at the navigation bar iirc. Or is there a reason for keeping the network selector at the navigation bar for now?

Copy link
Contributor

@superical superical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge this PR whenever you are ready.👍

PS: Use "squash and merge"

@osslgtm osslgtm merged commit be3ce0d into feat/multi-chain Feb 23, 2022
@osslgtm osslgtm deleted the feat/tailwindcss-migration branch February 23, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants