fix(badge): css variables used as privately #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
@buseselvi I added 2 more stories to test small badge with icon (we hide icon in this case) and large badge with icon. Can you please check them on Chromatic? |
DamlaDemir
approved these changes
Aug 5, 2022
buseselvi
approved these changes
Aug 5, 2022
|
🎉 This PR is included in version 2.0.0-beta.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
Merged
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed in #164, it was not possible to set badge CSS variables from upper levels of dom tree because default values set in
:hostselector. This was causing difficulties to style badge intabcomponent, because we use badge inside tab component's shadow dom and it's not possible to query badge inside tab in CSS. This makes CSS variables of badge component like a theme variables, so user can set those variables in any scope (badge component level, parent component level or document level).