Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContactShadows demo throws error #230

Closed
5 tasks done
andretchen0 opened this issue Sep 22, 2023 · 4 comments
Closed
5 tasks done

ContactShadows demo throws error #230

andretchen0 opened this issue Sep 22, 2023 · 4 comments
Labels
bug Something isn't working p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@andretchen0
Copy link
Contributor

andretchen0 commented Sep 22, 2023

Describe the bug

The guide page at:

https://cientos.tresjs.org/guide/staging/contact-shadows.html

throws an error:

Uncaught (in promise) TypeError: "position" is read-only

This appears related to ContactShadows helper prop:

  • When true, the error is thrown.
  • Whenfalse, the error is not thrown.

Reproduction

https://stackblitz.com/edit/tresjs-basic-pfyd2g?file=src%2Fcomponents%2FTheExperience.vue

Steps to reproduce

System Info

System:
    OS: macOS 13.1
    CPU: (8) arm64 Apple M1
    Memory: 102.31 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 20.5.1 - /opt/homebrew/bin/node
    npm: 9.8.0 - /opt/homebrew/bin/npm
    pnpm: 8.6.5 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 116.0.5845.187
    Safari: 16.2
  npmPackages:
    @tresjs/core: ^3.2.1 => 3.2.1 
    @tresjs/eslint-config-vue: ^0.1.1 => 0.1.1 
    vite: ^4.4.9 => 4.4.9

Used Package Manager

pnpm

Code of Conduct

@andretchen0
Copy link
Contributor Author

andretchen0 commented Dec 14, 2023

Additional ContactShadows problems, in ./playground/src/pages/staging/ContactShadowsDemo.vue

  • the shadows disappear when the "resolution" slider is changed in the UI
  • the shadow color doesn't change when state.color is changed in the UI

For clarity, the UI is currently being ported from TweakPane to TresLeches. But the problems occur regardless of the UI library used.

Here's the Leches version of the UI in question:

Screenshot 2023-12-14 at 15 18 37

@alvarosabu – I noticed the above when porting the UI to Leches. Just in case you want to take a look.

@alvarosabu alvarosabu added the bug Something isn't working label Dec 15, 2023 — with Volta.net
Copy link
Member

Hi @andretchen0 I think there are several issues with that component and reactivity, I will take it

@JaimeTorrealba
Copy link
Member

Should we close this one? @alvarosabu @andretchen0

@andretchen0
Copy link
Contributor Author

Closing. Completed by #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
Status: Done
Development

No branches or pull requests

3 participants