feat(app): 421 Update components to use useLoop instead of useRenderLoop

[JaimeTorrealba]

close #421

• Stats.ts
• StatsGL
• Ocean (need test, related to Linter is breaking some props #411 )
• Smoke
• useEnvironment
• Html
• KeyboardControls
• ContactShadows (demo not working @alvarosabu, related to ContactShadows demo throws error #230)
• Levioso
• ScrollControls
• useAnimations
• Precipitation
• HolographicMaterial (need test, related to Linter is breaking some props #411)
• MeshWobbleMaterial
• OrbitControls
• MouseParallax
• CameraControls
• Sparkles (demo not working)

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[JaimeTorrealba]

Hi, currently 3 main things are missing for this one

@alvarosabu could you check please the lint problems with ocean (a problem with the demo that uses SKY) and holographic

@andretchen0 for some reason, Sparkles is not updating can you help me with this one

Contact shadows also have problems, but this comes before.

And useEnviroment needs to be checked (I will do this)

Thanks :)

[alvarosabu]

Sure @JaimeTorrealba, I already fixed the issue of the linting for Sky and holographic here #424, just checked Ocean and is solved as well, once that is merge you can merge it here to do the update

For contact shadows the issues are different, it will require its own ticket

[andretchen0]

Unsure about Sparkles. Maybe we take it offline for now so this can move forward.

I checked it after the linter was updated.

I'm guessing an underlying dependency updated, but I can't find the source atm.

[JaimeTorrealba]

Consider that the ContactShadows and the sparkles will be out of the scope of this PR.

Can we merge this one? @alvarosabu @andretchen0

[alvarosabu]

Consider that the ContactShadows and the sparkles will be out of the scope of this PR.

Can we merge this one? @alvarosabu @andretchen0

If we take out those 2 yes, I will take over the ContactShadows 👌

[andretchen0]

As mentioned on Discord, it seems that the problem with Sparkles and ContactShadows are due to changes in the way primitive is handled by the v4 core.

Considering the amount work that @JaimeTorrealba has done here, I think it'd be best to merge now and recheck after fixing primitives in the core. But I'll leave that decision up to you two, @alvarosabu @JaimeTorrealba .

[alvarosabu]

I agree with @andretchen0, please @JaimeTorrealba check the conflict on the package.json and we are ready to merge