Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: change defineExpose value.value to value.instance #392

Merged
merged 5 commits into from
May 5, 2024

Conversation

andretchen0
Copy link
Contributor

@andretchen0 andretchen0 commented May 1, 2024

Context

closes #160

Progress

AT JT AS file former current or comment
src/core/abstractions/AnimatedSprite/component.vue no defineExpose instance
src/core/abstractions/Lensflare/component.vue value instance
src/core/abstractions/useFBO/component.vue value instance
src/core/abstractions/useSurfaceSampler/component.vue nothing to do
src/core/abstractions/GlobalAudio.vue no defineExpose
src/core/abstractions/Levioso.vue value instance
src/core/abstractions/MouseParallax.vue nothing to do
src/core/abstractions/Reflector.vue reflectorRef instance
src/core/abstractions/Text3D.vue value instance
src/core/abstractions/useAnimations.ts nothing to do
src/core/controls/CameraControls.vue value instance
src/core/controls/KeyboardControls.vue value instance
src/core/controls/MapControls.vue no defineExpose instance
src/core/controls/OrbitControls.vue value instance
src/core/controls/PointerLockControls.vue value instance
src/core/controls/ScrollControls.vue no defineExpose instance
src/core/controls/TransformControls.vue no defineExpose instance
src/core/loaders/SVG/component.vue value instance
src/core/loaders/useFBX/component.vue value instance
src/core/loaders/useGLTF/component.vue value instance
src/core/loaders/useProgress nothing to do
src/core/loaders/useVideoTexture nothing to do
src/core/materials/customShaderMaterial/index.vue value instance
src/core/materials/meshGlassMaterial/index.vue MeshGlassMaterialClass exposed instance
src/core/materials/meshReflectionMaterial/index.vue no defineExpose instance
src/core/materials/meshWobbleMaterial/index.vue no defineExpose instance
src/core/misc/html/HTML.vue no defineExpose instance
src/core/misc/useTweakPane/index.ts nothing to do
src/core/misc/BakeShadows nothing to do
src/core/misc/Stats.ts exposes stats
src/core/misc/Stats.ts exposes statsGl
src/core/misc/useGLTFExporter.ts nothing to do
src/core/shapes/Box.vue value instance
src/core/shapes/CatmullRomCurve3.vue no defineExpose instance
src/core/shapes/Circle.vue value instance
src/core/shapes/Cone.vue value instance
src/core/shapes/Dodecahedron.vue value instance
src/core/shapes/Icosahedron.vue value instance
src/core/shapes/Line2.vue no defineExpose instance
src/core/shapes/Octahedron.vue value instance
src/core/shapes/Plane.vue value instance
src/core/shapes/Ring.vue value instance
src/core/shapes/RoundedBox.vue value instance
src/core/shapes/Sphere.vue value instance
src/core/shapes/Superfomula.vue value instance
src/core/shapes/Tetrahedron.vue value instance
src/core/shapes/Torus.vue value instance
src/core/shapes/TorusKnot.vue value instance
src/core/shapes/Tube.vue value instance
src/core/staging/Sparkles/component.vue no defineExpose instance
src/core/staging/useEnvironment/component.vue docs demo doesn't load
src/core/staging/Backdrop.vue no defineExpose instance
src/core/staging/ContactShadows.vue playground/docs demo have errors
src/core/staging/Ocean.vue root instance
src/core/staging/Precipitation.vue no defineExpose instance
src/core/staging/Sky.vue root instance
src/core/staging/Smoke.vue value instance
src/core/staging/Stars.vue value instance
src/utils/index.ts value.value left as is

Copy link

stackblitz bot commented May 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@andretchen0
Copy link
Contributor Author

andretchen0 commented May 1, 2024

@JaimeTorrealba @alvarosabu

Above is a list of changes made to Cientos files.

I've marked with a ✅, all the files that I created or where the change to instance appeared straightforward.

Especially those components without a ✅ require attention.

If it's helpful, there's a column for each of you in the table. If not, no worries. Just approve, etc. the PR.

Feel free to push changes to this branch.


As of 1c4c569, I have:

  • tested all Cientos playground demos
  • tested all Cientos docs pages for errors

I have not tested anything outside of the Cientos package, e.g., Labs.

@JaimeTorrealba JaimeTorrealba added v4 breaking-change p3-significant High-priority enhancement (priority) labels May 1, 2024
@JaimeTorrealba
Copy link
Member

Let me take a look to the other components @andretchen0 and thanks for the big work

@JaimeTorrealba
Copy link
Member

JaimeTorrealba commented May 3, 2024

There is an issue for the contact shadow #230.

The case of the enviroment component is weird it doesn't return the texture but if I logged it appears. Anyways we can solve them later. The rest of the components I think doesn't apply for this "migration"

If you agree we can merge now to the v4

@andretchen0
Copy link
Contributor Author

@JaimeTorrealba , sounds good.

@alvarosabu , do you want to have a look before we merge?

Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add, amazing job 💚

@JaimeTorrealba JaimeTorrealba merged commit 661302c into v4 May 5, 2024
2 checks passed
@andretchen0 andretchen0 deleted the refactor/defineExpose branch May 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change p3-significant High-priority enhancement (priority) v4
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants