-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: change defineExpose value.value to value.instance #392
Conversation
|
Above is a list of changes made to Cientos files. I've marked with a ✅, all the files that I created or where the change to Especially those components without a ✅ require attention. If it's helpful, there's a column for each of you in the table. If not, no worries. Just approve, etc. the PR. Feel free to push changes to this branch. As of 1c4c569, I have:
I have not tested anything outside of the Cientos package, e.g., Labs. |
Let me take a look to the other components @andretchen0 and thanks for the big work |
There is an issue for the contact shadow #230. The case of the enviroment component is weird it doesn't return the texture but if I logged it appears. Anyways we can solve them later. The rest of the components I think doesn't apply for this "migration" If you agree we can merge now to the v4 |
@JaimeTorrealba , sounds good. @alvarosabu , do you want to have a look before we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add, amazing job 💚
Context
closes #160
Progress
defineExpose
instance
value
instance
value
instance
defineExpose
value
instance
reflectorRef
instance
value
instance
value
instance
value
instance
defineExpose
instance
value
instance
value
instance
defineExpose
instance
defineExpose
instance
value
instance
value
instance
value
instance
value
instance
MeshGlassMaterialClass
exposedinstance
defineExpose
instance
defineExpose
instance
defineExpose
instance
stats
statsGl
value
instance
defineExpose
instance
value
instance
value
instance
value
instance
value
instance
defineExpose
instance
value
instance
value
instance
value
instance
value
instance
value
instance
value
instance
value
instance
value
instance
value
instance
value
instance
defineExpose
instance
defineExpose
instance
root
instance
defineExpose
instance
root
instance
value
instance
value
instance
value.value