-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tag community, database and REST API endpoints #6396
Conversation
acce8af
to
cef9e7d
Compare
src/tribler-core/tribler_core/components/tag/community/tag_payload.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_community.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_payload.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_community.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/metadata_store/db/orm_bindings/tag.py
Outdated
Show resolved
Hide resolved
d7c8429
to
efde2e4
Compare
src/tribler-core/tribler_core/components/metadata_store/db/orm_bindings/channel_node.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_community.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_community.py
Outdated
Show resolved
Hide resolved
45fe78e
to
bbcec9f
Compare
src/tribler-core/tribler_core/components/tag/restapi/tags_endpoint.py
Outdated
Show resolved
Hide resolved
Feel free to add these tests in this PR, I can just rebase my branch when you make changes (adding tests to this PR should not merge conflict with my work). 👍 |
src/tribler-core/tribler_core/components/tag/community/tests/test_tag_community.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tests/test_tag_community.py
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_validator.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_validator.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tests/test_tag_request_controller.py
Outdated
Show resolved
Hide resolved
5f95718
to
333fa1e
Compare
@drew2a I notice that there are a few uncovered lines which could probably be covered with a carefully designed test (e.g., in the Also, I think the remaining pylint errors can be fixed 👍 |
798608d
to
a016b30
Compare
src/tribler-core/tribler_core/components/tag/community/tag_crypto.py
Outdated
Show resolved
Hide resolved
09b0b88
to
7b47c18
Compare
src/tribler-core/tribler_core/components/tag/community/tag_community.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_community.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/restapi/tags_endpoint.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/popularity/tests/test_popularity_component.py
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/restapi/tags_endpoint.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_community.py
Outdated
Show resolved
Hide resolved
8f3221f
to
2841e72
Compare
src/tribler-core/tribler_core/components/metadata_store/utils.py
Outdated
Show resolved
Hide resolved
50e9c9b
to
8305fef
Compare
Filtering tags in the REST API Simplify test_get_my_channel_tags_xxx Add TagDb.get_tags_operations_for_gossip() Change timer to counter Add lower-case validation to TagValidator Converting tags to lower-case in REST API Ensure that random tags during tests are lowercase Extend Tests Apply ipv8 dataclass Refactor TagCommunity PR fixes Add TagSerializer Refactoring DB: counter for peer, timestamp for operations Appending tags to search results Also extended the search GUI test to return more results. PyLint Refactor message raw serialisation Fix merge conflicts PR fixes Remove unused const
8305fef
to
cb7db06
Compare
Kudos, SonarCloud Quality Gate passed!
|
A test on Windows 64-bit is failing:
That's unexpected since this test looks deterministic. Let's see if this persists. |
retest this please |
This PR contains core-side logic for #6214
Design decisions behind the Community:
Design decisions behind the DB: