Tag System: Revert {pk, tag, infohash} clock #6475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
feature/tag_counter
branch
3 times, most recently
from
0be7952 to
ebb05ef
Compare
drew2a
force-pushed
the
feature/tag_counter
branch
from
ebb05ef to
8126885
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
drew2a
requested review from
a team,
xoriole,
devos50 and
kozlovsky
and removed request for
a team
devos50
approved these changes
Oct 21, 2021
kozlovsky
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the original logic of clocks from #6396 to provide the correct order of received tag operations based on causality.
Clocks are now based on triplets:
{public_key, tag, infohash}.This PR updates the ipv8 pointer to get the support of correct hints for dataclasses as well.
Related to #6214