Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] nginx 용량 수정 #99

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[Fix] nginx 용량 수정 #99

merged 1 commit into from
Jun 13, 2024

Conversation

Leegiyeon
Copy link
Member

PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 코드 및 구조 개선

반영 브랜치

hot fix -> main

변경 사항

파일 업로드 용량을 키우는 설정을 가진 ocnfig파일을 추가했습니다.

@Leegiyeon Leegiyeon added bug Something isn't working enhancement New feature or request release release service labels Jun 13, 2024
@Leegiyeon Leegiyeon self-assigned this Jun 13, 2024
owner: "root"
group: "root"
content: |
client_max_body_size 100M; No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code patch seems to be a YAML snippet intended for configuration management tools like Ansible or Puppet. Here's a brief review based on the provided information:

  1. Bug risk:

    • No obvious bugs in this snippet. It looks correct for its intended purpose.
  2. Improvement suggestions:

    • Consider adding a newline at the end of the content block to adhere to conventions and for readability.
    • Ensure that the file path "/etc/nginx/conf.d/proxy.conf" is accurate and matches your system's configuration.
  3. Potential enhancements:

    • Parameterize values like file paths, permissions, and content to make the script more reusable and versatile.
    • Error handling can be added to manage scenarios where the file cannot be created/modified successfully.
    • Check if the configuration change requires an Nginx restart/reload to take effect and handle this if necessary.

Remember that this review is based solely on the provided snippet, and additional context or code would be required for a more comprehensive assessment.

@Leegiyeon
Copy link
Member Author

Database 환경 수정됨에 따라 CI 제하고 배포 진행하도록 하겠습니다!

@Leegiyeon Leegiyeon merged commit 0146b80 into main Jun 13, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request release release service
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant