Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule: Avoid multiple DML events per trigger. #84

Closed
PhilippSalvisberg opened this issue Sep 14, 2020 · 1 comment · Fixed by #86
Closed

New Rule: Avoid multiple DML events per trigger. #84

PhilippSalvisberg opened this issue Sep 14, 2020 · 1 comment · Fixed by #86
Assignees
@kibeha
Labels
enhancement New feature or request
Milestone
v4.0

Comments

@PhilippSalvisberg
Copy link
Collaborator

Connor McDonald posted a video on LinkedIn named When MORE triggers means better performance!.

He explains that multiple DML events per trigger can cause additional locks and therefore performance issues. The solution is to define a trigger per event (or avoid triggers if possible of course).

I think this would make a fine rule and it is easy to check.
@PhilippSalvisberg PhilippSalvisberg added the enhancement New feature or request label Sep 14, 2020
@kibeha
Copy link
Collaborator

kibeha commented Sep 16, 2020

Makes sense. Will make a rule for this.

@kibeha kibeha added this to the v4.0 milestone Sep 16, 2020
@kibeha kibeha self-assigned this Sep 16, 2020
kibeha added a commit to kibeha/plsql-and-sql-coding-guidelines that referenced this issue Sep 16, 2020
@kibeha
Fix Trivadis#84 - Created rule G-7730: Avoid multiple DML events per …
865aac4 
…trigger if primary key is assigned in trigger.
@kibeha kibeha mentioned this issue Sep 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kibeha kibeha

Labels
enhancement New feature or request
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Changes for version 4.0 kibeha/plsql-and-sql-coding-guidelines
2 participants
@PhilippSalvisberg @kibeha