Changes for version 4.0 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of codehilite markdown extension for syntax highlighting and line numbers of SQL & PL/SQL.
… to G-3310 and G-3320. Fixed links for these rules in PDF.
…ason and importance of consistency. Converted all code examples to lowercase (thanks Philipp for https://www.salvis.com/blog/2020/08/28/formatting-sql-code-blocks-in-markdown-files/ )
…itialization block.
…n trigger event clause.
…ns in different branches of the same IF or CASE statement.
…samples that automatic script didn't handle. Fixed a few typos along the way.
…l variables that are not used by a subsequent statement.
…trigger if primary key is assigned in trigger.
… to boolean literals.
…in G-7230 concerning public constants.
…G-1050 exist (like Logger)
… case of proper use of Logger.
docs/4-language-usage/4-control-structures/2-case-if-decode-nvl-nvl2-coalesce/g-4260.md
Show resolved
Hide resolved
There was a problem hiding this comment.
The following rules are currently not supported by a PL/SQL Cop validator:
- G-3160 (cannot identify type of a column)
- G-5010 (cannot identify logging framework and where it should be applied)
- G-8410 (cannot identify where an application lock would make sense)
- G-8510 (cannot know where the use of application_info is sensible)
They should be tagged with "!!! missing "Unsupported in PL/SQL Cop Validators"
PhilippSalvisberg
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Great work. Thanks Kim!
I scanned the following
- each changed file
- browsed through every HTML page
- browsed through the complete PDF
All of my comments are suggestions. Feel free to ignore them or apply them later. Up to you. You may merge this PR whenever you are ready.
There were a lot of changes due to the change of keywords from uppercase to lowercase. And not all codes were changed automatically. And finding the missing ones was possible only with looking at the source/result manually.
Thanks again.
Philipp
This was referenced Sep 23, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
Closes #25
Closes #27
Closes #30
Closes #31
Closes #38
Closes #44
Closes #45
Closes #48
Closes #57
Closes #77
Closes #78
Closes #79
Closes #81
Closes #84
Closes #85