Use custom serializer for snake case #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NewWord | ||
| } | ||
|
|
||
| public static string ToSnakeCase(this string s) |
There was a problem hiding this comment.
This looks prime for Benchmark .NET 😄
test/Sdk.Tests/Common/Serialization/SnakeCaseNamingPolicyTests.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/TrueLayerSdk/TrueLayerSdk.csproj
tl-ben-foster
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
snake_casesupport when serializing/deserializing request adn responses.Here is the main issue tracked on the dotnet repo, to add
snake_casesupport directly ontoSystem.Text.Json.And this is a proposed implementation, which could be approved for .NET 6. It is very similar to the
Newtonsoftone.This way we avoid having lots of
[JsonPropertyName]around the codebase, and when .NET 6 is out, it will almost be a single line change on our side.Close #4