Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Add support for JsonSnakeNamingPolicy #40003

Closed
wants to merge 1 commit into from
Closed

Add support for JsonSnakeNamingPolicy #40003

wants to merge 1 commit into from

Conversation

hez2010
Copy link

@hez2010 hez2010 commented Aug 4, 2019

  • Add JsonSnakeNamingPolicy support
  • Add tests for JsonSnakeNamingPolicy

Fixed #39564

* Add JsonSnakeNamingPolicy support
* Add tests for JsonSnakeNamingPolicy
@danmoseley danmoseley added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 4, 2019
@Gnbrkm41
Copy link

Gnbrkm41 commented Aug 4, 2019

Shouldn't this go through the API review process though, no? https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/api-review-process.md

@hez2010
Copy link
Author

hez2010 commented Aug 4, 2019

@Gnbrkm41 It had been added to the 5.0 milestone so I think that I can implement it in advance :)
And it's really useful in json serialization/deserialization, if there's no snake case in System.Text.Json, many people who migrate from Newtonsoft.Json to System.Text.Json would face breaking changes and they will have to implement it by themselves.

@Gnbrkm41
Copy link

Gnbrkm41 commented Aug 4, 2019

Being added to milestones doesn't mean it's approved; every single thing about the public APIs should be thoroughly discussed, marked as ready for review when the area owner thinks it's solid enough, reviewed by the review team then approved in order to actually be implemented.

The Pull Request section of the API review process document says:

Pull requests against corefx shouldn't be submitted before getting approval. Also, we don't want to get work in progress (WIP). The reason being that we want to reduce the number pending PRs so that we can focus on the work the community expects we take action on.

@danmoseley
Copy link
Member

I'm going to close for reason mentioned above. Let's continue discussion on the issue. Thanks.

@danmoseley danmoseley closed this Aug 4, 2019
@karelz karelz added this to the 5.0 milestone Aug 9, 2019
database64128 added a commit to database64128/shadowsocks-uri-generator that referenced this pull request Sep 9, 2020
- For the use of online configuration generation
- Source: dotnet/corefx#40003
- See also: dotnet/runtime#782
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add snake_case support for System.Text.Json
5 participants