fix(windows): fix local process manager on windows #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this pull request
Jul 21, 2017
closes TryGhost#368 - force killing on mac/linux doesn't allow the child process (ghost run) to kill the ghost server process, resulting in a orphan process that the user has to kill manually - on windows force: true works because fkill kills the process tree, which includes the ghost server - remove windows-specific code from TryGhost#366 as it actually didn't do anything
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this pull request
Jul 21, 2017
closes TryGhost#368 - force killing on mac/linux doesn't allow the child process (ghost run) to kill the ghost server process, resulting in a orphan process that the user has to kill manually - on windows force: true works because fkill kills the process tree, which includes the ghost server - remove windows-specific code from TryGhost#366 as it actually didn't do anything
3 tasks
acburdine
added a commit
that referenced
this pull request
Jul 21, 2017
closes #368 - force killing on mac/linux doesn't allow the child process (ghost run) to kill the ghost server process, resulting in a orphan process that the user has to kill manually - on windows force: true works because fkill kills the process tree, which includes the ghost server - remove windows-specific code from #366 as it actually didn't do anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #228